Skip to content

[maven-generator] Do not cleanup output if spec file is unchanged and skipIfSpecIsUnchanged=true (Fixes #16490)#16491

Merged
wing328 merged 2 commits into
OpenAPITools:masterfrom
Philzen:16490-do-not-cleanup-output-if-spec-is-unchanged
Sep 12, 2023
Merged

[maven-generator] Do not cleanup output if spec file is unchanged and skipIfSpecIsUnchanged=true (Fixes #16490)#16491
wing328 merged 2 commits into
OpenAPITools:masterfrom
Philzen:16490-do-not-cleanup-output-if-spec-is-unchanged

Conversation

@Philzen

@Philzen Philzen commented Sep 3, 2023

Copy link
Copy Markdown
Contributor

Closes #16490

@Philzen Philzen requested a review from jimschubert as a code owner September 3, 2023 11:39
@Philzen Philzen changed the title Do not cleanup output if spec file is unchanged [maven-generator] Do not cleanup output if spec file is unchanged (Fixes #16490) Sep 3, 2023
@Philzen Philzen changed the title [maven-generator] Do not cleanup output if spec file is unchanged (Fixes #16490) [maven-generator] Do not cleanup output if spec file is unchanged and skipIfSpecIsUnchanged=true (Fixes #16490) Sep 3, 2023
@wing328

wing328 commented Sep 6, 2023

Copy link
Copy Markdown
Member

@Philzen thanks for the PR. Have you tested it locally to ensure it's working for your use cases?

@wing328

wing328 commented Sep 12, 2023

Copy link
Copy Markdown
Member

let's give it a try. thanks for the PR.

@wing328 wing328 merged commit 196c2b1 into OpenAPITools:master Sep 12, 2023
@wing328 wing328 added this to the 7.0.1 milestone Sep 12, 2023
@Philzen

Philzen commented Oct 9, 2023

Copy link
Copy Markdown
Contributor Author

@wing328 Apologies for not replying on this earlier. At the time of this PR, all the projects i was working on were still on Java 8 and Spring Boot 2.1, when i discovered this on my research regarding a migration path. I purely inferred the bug and its fix from looking at the code, hence i couldn't test this at the time.

Now the migration to SB 3.1 and openapitools 7.0.1 is in full swing and i was able to test thoroughly.
I am happy to confirm that #16490 was definitely a thing up to <= 7.0.0 and this fix did exactly what it was supposed to do.

For the record, release notes respectively, <cleanupOutput> was introduced in 4.0.2 and in 7.01 finally started to work smooth as silk in conjunction with skipIfSpecIsUnchanged.

@Philzen Philzen deleted the 16490-do-not-cleanup-output-if-spec-is-unchanged branch October 9, 2023 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] [maven generator] cleanupOutput breaks skipIfSpecIsUnchanged

2 participants