Skip to content

[PHP-SYMFONY] Debug Symfony version 7, enums ref, array of enums $ref and date assert#19008

Merged
wing328 merged 3 commits into
OpenAPITools:masterfrom
loicconan:php-symfony-version-7-enums-ref-date
Jun 30, 2024
Merged

[PHP-SYMFONY] Debug Symfony version 7, enums ref, array of enums $ref and date assert#19008
wing328 merged 3 commits into
OpenAPITools:masterfrom
loicconan:php-symfony-version-7-enums-ref-date

Conversation

@loicconan

Copy link
Copy Markdown
Contributor

For: @jebentier (2017/07), @dkarlovi (2017/07), @mandrean (2017/08), @jfastnacht (2017/09), @ybelenko (2018/07), @renepardon (2018/12)

Description

  • Improve Symfony 7 support by replacing assert annotation (no longer supported since version 7)
  • Debug datetime and date assert
  • Debug enum $ref for deserialization
  • Implement array of enum $ref

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh ./bin/configs/*.yaml
    ./bin/utils/export_docs_generators.sh
    
    (For Windows users, please run the script in Git BASH)
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
  • File the PR against the correct branch: master (upcoming 7.6.0 minor release - breaking changes with fallbacks), 8.0.x (breaking changes without fallbacks)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@wing328

wing328 commented Jun 26, 2024

Copy link
Copy Markdown
Member

Thanks for the PR but your commit (as shown in the Commits tab) is not linked to your Github account, which means this PR won't count as your contribution in https://github.com/OpenAPITools/openapi-generator/graphs/contributors.

Let me know if you need help fixing it.

Ref: https://github.com/OpenAPITools/openapi-generator/wiki/FAQ#how-can-i-update-commits-that-are-not-linked-to-my-github-account

@loicconan loicconan force-pushed the php-symfony-version-7-enums-ref-date branch 2 times, most recently from f07fad9 to bdf4865 Compare June 26, 2024 07:43
@loicconan loicconan force-pushed the php-symfony-version-7-enums-ref-date branch from bdf4865 to 7edfddb Compare June 26, 2024 07:45
@loicconan

Copy link
Copy Markdown
Contributor Author

Thanks for the PR but your commit (as shown in the Commits tab) is not linked to your Github account, which means this PR won't count as your contribution in https://github.com/OpenAPITools/openapi-generator/graphs/contributors.

Let me know if you need help fixing it.

Ref: https://github.com/OpenAPITools/openapi-generator/wiki/FAQ#how-can-i-update-commits-that-are-not-linked-to-my-github-account

Oh yes that was my pro email.

Fixed it !

Thx.

@wing328

wing328 commented Jun 30, 2024

Copy link
Copy Markdown
Member

tested locally and the result is good

Tests: 63, Assertions: 22, Deprecations: 116, Skipped: 47, Risky: 20.
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time:  4.531 s
[INFO] Finished at: 2024-06-30T10:10:48+08:00
[INFO] ------------------------------------------------------------------------
[INFO] 3 goals, 3 executed

thanks for the PR

@wing328 wing328 merged commit fb17e56 into OpenAPITools:master Jun 30, 2024
@wing328 wing328 added this to the 7.7.0 milestone Jun 30, 2024
@wing328

wing328 commented Jan 5, 2025

Copy link
Copy Markdown
Member

@loicconan thanks again for the PR

when you've time, can you please PM me via Slack?

https://join.slack.com/t/openapi-generator/shared_invite/zt-2wmkn4s8g-n19PJ99Y6Vei74WMUIehQA

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants