Support Helidon SE 4 generation (clients and servers)#19150
Merged
Conversation
Contributor
|
Hi @tjquinno, thanks for the PR! Could you please merge the latest master to fix the failing java-camel test? And update the samples, to fix the other failing check? |
…nnotation selectively
…confusing builds and up-to-date samples checking
…roup operations rather than the tags items
tjquinno
force-pushed
the
helidon-4-support-se-b
branch
from
August 3, 2024 18:53
15d414f to
da2dcec
Compare
Contributor
Author
|
@martin-mfg Done. Didn't realize I'd missed a few Helidon sample files in my earlier push but they are there now. Thanks. |
martin-mfg
approved these changes
Aug 4, 2024
Contributor
Author
|
@martin-mfg Thanks very much for the comments and the approval. I do not have permission to merge PRs in this repo. I am not sure whether @wing328 would want to do so himself or whether that's something you could do on my behalf. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #19148 to support generation of Helidon SE 4 clients and servers. (MP clients and servers were addresses in the earlier PR #18627.)
Resolves helidon-io/helidon#8879
Resolves helidon-io/helidon#8880
Key changes:
Update the
pom.xmltemplate.Update workflows.
Add the new v4 SE samples (one client, two servers) to the GitHub workflow triggers and scope. The second server sample selects the
useAbstractClassoption (note the-uacsuffix in the directory and.yamlnames) which creates quite a different project.Significant enhancements to the generated API and API implementation types.
There are several new template files (used only for generation of Helidon 4-compatible projects) and, in some cases, substantial conditionalization of existing templates to differentiate between Helidon 3 vs. Helidon 4 (and later) generation.
handle<operationId>method. Each parameter is extracted in its own uniquely-named method so, if needed, developers can easily override selected methods. The generated code leverages features in Helidon 4 to decode each incoming parameter to the correct type.Resultwith innerrecords for each response declared in the OpenAPI document for the operation. Each response record enforces required output headers and/or the response body output. As developers implement thehandle<operationId>methods they can (but need not) use these records to easily prepare and send the HTTP response.Many, many samples files are new or adjusted with this PR (leading to the large number of changed files).
PR checklist
Commit all changed files.
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*.IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
master(upcoming 7.6.0 minor release - breaking changes with fallbacks),8.0.x(breaking changes without fallbacks)