Skip to content

fix(kotlin): set isVoid to true for Unit datatypes #21940

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
wing328 merged 1 commit into from
Sep 11, 2025
Merged

fix(kotlin): set isVoid to true for Unit datatypes #21940

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions ...api-generator/src/main/java/org/openapitools/codegen/languages/AbstractKotlinCodegen.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1119,6 +1119,8 @@ protected ImmutableMap.Builder<String, Mustache.Lambda> addMustacheLambdas() {
}

protected interface DataTypeAssigner {
void setIsVoid(Boolean isVoid);

void setReturnType(String returnType);

void setReturnContainer(String returnContainer);
Expand All @@ -1131,6 +1133,7 @@ protected interface DataTypeAssigner {
protected void doDataTypeAssignment(final String returnType, DataTypeAssigner dataTypeAssigner) {
if (returnType == null) {
dataTypeAssigner.setReturnType("Unit");
dataTypeAssigner.setIsVoid(true);
} else if (returnType.startsWith("kotlin.collections.List")) {
int end = returnType.lastIndexOf(">");
if (end > 0) {
Expand Down
9 changes: 9 additions & 0 deletions ...enapi-generator/src/main/java/org/openapitools/codegen/languages/KotlinServerCodegen.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -418,6 +418,11 @@ public OperationsMap postProcessOperationsWithModels(OperationsMap objs, List<Mo
}

doDataTypeAssignment(resp.dataType, new DataTypeAssigner() {
@Override
public void setIsVoid(Boolean isVoid) {
resp.isVoid = isVoid;
}

@Override
public void setReturnType(final String returnType) {
resp.dataType = returnType;
Expand All @@ -432,6 +437,10 @@ public void setReturnContainer(final String returnContainer) {
}

doDataTypeAssignment(operation.returnType, new DataTypeAssigner() {
@Override
public void setIsVoid(Boolean isVoid) {
operation.isVoid = isVoid;
}

@Override
public void setReturnType(final String returnType) {
Expand Down
9 changes: 9 additions & 0 deletions ...generator/src/main/java/org/openapitools/codegen/languages/KotlinSpringServerCodegen.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -880,6 +880,11 @@ public OperationsMap postProcessOperationsWithModels(OperationsMap objs, List<Mo
resp.baseType = getNonMutableContainerTypeIfNeeded(resp.baseType);

doDataTypeAssignment(resp.dataType, new DataTypeAssigner() {
@Override
public void setIsVoid(Boolean isVoid) {
resp.isVoid = isVoid;
}

@Override
public void setReturnType(final String returnType) {
resp.dataType = returnType;
Expand All @@ -904,6 +909,10 @@ public void setReturnContainer(final String returnContainer) {
}

doDataTypeAssignment(operation.returnType, new DataTypeAssigner() {
@Override
public void setIsVoid(Boolean isVoid) {
operation.isVoid = isVoid;
}

@Override
public void setReturnType(final String returnType) {
Expand Down
Loading