Skip to content

Remove rust-server-deprecated samples, workflow tests#24117

Merged
wing328 merged 1 commit into
masterfrom
rust-server-deprecate-skip-tests
Jun 24, 2026
Merged

Remove rust-server-deprecated samples, workflow tests#24117
wing328 merged 1 commit into
masterfrom
rust-server-deprecate-skip-tests

Conversation

@wing328

@wing328 wing328 commented Jun 24, 2026

Copy link
Copy Markdown
Member

PR checklist

  • Read the contribution guidelines.
  • Run the following to build the project and update samples:
    ./mvnw clean package || exit
    ./bin/generate-samples.sh ./bin/configs/*.yaml || exit
    ./bin/utils/export_docs_generators.sh || exit
    
    (For Windows users, please run the script in WSL)
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

Summary by cubic

Remove all rust-server-deprecated samples and stop running their CI tests. This reduces maintenance and speeds up the samples workflow.

  • Refactors
    • Deleted bin/configs/rust-server-deprecated-*.yaml and the entire samples/server/petstore/rust-server-deprecated directory.
    • Updated .github/workflows/samples-rust-server.yaml to remove rust-server-deprecated from the matrix.

Written for commit 56cf7d4. Summary will update on new commits.

Review in cubic

@wing328 wing328 changed the title remove rust-server-deprecated samples, workflow tests Remove rust-server-deprecated samples, workflow tests Jun 24, 2026
@wing328 wing328 added this to the 7.24.0 milestone Jun 24, 2026
@wing328 wing328 marked this pull request as ready for review June 24, 2026 09:35

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 306 files

Note: This PR contains a large number of files. cubic only reviews up to 100 files per PR, so some files may not have been reviewed. cubic prioritizes the most important files to review.
On a pro plan you can use ultrareview for larger PRs.

Re-trigger cubic

@wing328 wing328 merged commit 73ab398 into master Jun 24, 2026
16 checks passed
@wing328 wing328 deleted the rust-server-deprecate-skip-tests branch June 24, 2026 09:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant