Skip to content

Add tests to cover #24192#24195

Merged
wing328 merged 1 commit into
masterfrom
followup-24192
Jul 3, 2026
Merged

Add tests to cover #24192#24195
wing328 merged 1 commit into
masterfrom
followup-24192

Conversation

@wing328

@wing328 wing328 commented Jul 3, 2026

Copy link
Copy Markdown
Member

a follow up PR to #24192

PR checklist

  • Read the contribution guidelines.
  • Run the following to build the project and update samples:
    ./mvnw clean package || exit
    ./bin/generate-samples.sh ./bin/configs/*.yaml || exit
    ./bin/utils/export_docs_generators.sh || exit
    
    (For Windows users, please run the script in WSL)
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@wing328 wing328 changed the title add tests to cover #24192 Add tests to cover #24192 Jul 3, 2026
@wing328 wing328 added this to the 7.24.0 milestone Jul 3, 2026
@wing328 wing328 marked this pull request as ready for review July 3, 2026 07:30
@wing328 wing328 merged commit df45e93 into master Jul 3, 2026
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant