Skip to content

a followup PR to #24173 #24211

Merged
wing328 merged 2 commits into
masterfrom
24173-followup
Jul 6, 2026
Merged

a followup PR to #24173 #24211
wing328 merged 2 commits into
masterfrom
24173-followup

Conversation

@wing328

@wing328 wing328 commented Jul 6, 2026

Copy link
Copy Markdown
Member

a followup PR to #24173

PR checklist

  • Read the contribution guidelines.
  • Run the following to build the project and update samples:
    ./mvnw clean package || exit
    ./bin/generate-samples.sh ./bin/configs/*.yaml || exit
    ./bin/utils/export_docs_generators.sh || exit
    
    (For Windows users, please run the script in WSL)
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

Summary by cubic

Refocuses the MicroProfile Rest Client 3.0 Jackson sample on a minimal enum spec and expands enum.yaml to exercise enum parameters and values. Removes legacy Petstore models/APIs from the sample and drops jersey3 builds from the JDK11 workflow.

  • New Features

    • Add POST /ponies with enum query param status (form, explode=false, default, deprecated).
    • Add Type enum and extend IntegerEnum (values 1, 2, 4); update Pony model.
    • Update DefaultApi to /ponies GET/POST and switch base URL to http://localhost.
  • Refactors

    • Point bin/configs/java-microprofile-rest-client-3.0-jackson-ignore-case.yaml to 3_0/enum.yaml; regenerate outputs.
    • Remove Petstore APIs/models/docs from microprofile-rest-client-3.0-jackson-ignore-case; update headers and POM description to "Sample API".
    • CI: remove samples/client/petstore/java/jersey3 from the JDK11 workflow matrix.

Written for commit 2cea1ae. Summary will update on new commits.

Review in cubic

@wing328 wing328 added Client: Java Enhancement: CI/Test java Pull requests that update Java code and removed java Pull requests that update Java code labels Jul 6, 2026
@wing328 wing328 marked this pull request as ready for review July 6, 2026 08:23

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2 issues found across 183 files

Prompt for AI agents (unresolved issues)

Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.


<file name="samples/client/petstore/java/microprofile-rest-client-3.0-jackson-ignore-case/src/main/java/org/openapitools/client/api/DefaultApi.java">

<violation number="1" location="samples/client/petstore/java/microprofile-rest-client-3.0-jackson-ignore-case/src/main/java/org/openapitools/client/api/DefaultApi.java:64">
P2: The new `status` query parameter is modeled as `List<String>`, so callers can pass invalid values without compile-time checks. Modeling it as an enum list (or generated operation enum) would preserve the enum contract the sample is intended to demonstrate.</violation>
</file>

<file name="samples/client/petstore/java/microprofile-rest-client-3.0-jackson-ignore-case/docs/DefaultApi.md">

<violation number="1" location="samples/client/petstore/java/microprofile-rest-client-3.0-jackson-ignore-case/docs/DefaultApi.md:118">
P3: The `status` parameter on `poniesPost` is marked deprecated in the OpenAPI spec but the Notes column doesn't reflect it (no `[deprecated]` tag). Since this is auto-generated doc, check whether the generator template handles parameter-level `deprecated` — if not, the generated docs will silently drop this metadata and consumers won't see it.</violation>
</file>

Reply with feedback, questions, or to request a fix.

Re-trigger cubic

@POST

@Produces({ "application/json" })
List<Pony> poniesPost(@QueryParam("status") List<String> status) throws ApiException, ProcessingException;

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2: The new status query parameter is modeled as List<String>, so callers can pass invalid values without compile-time checks. Modeling it as an enum list (or generated operation enum) would preserve the enum contract the sample is intended to demonstrate.

Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. At samples/client/petstore/java/microprofile-rest-client-3.0-jackson-ignore-case/src/main/java/org/openapitools/client/api/DefaultApi.java, line 64:

<comment>The new `status` query parameter is modeled as `List<String>`, so callers can pass invalid values without compile-time checks. Modeling it as an enum list (or generated operation enum) would preserve the enum contract the sample is intended to demonstrate.</comment>

<file context>
@@ -30,19 +30,36 @@
+    @POST
+    
+    @Produces({ "application/json" })
+    List<Pony> poniesPost(@QueryParam("status") List<String> status) throws ApiException, ProcessingException;
 }
</file context>


| Name | Type | Description | Notes |
|------------- | ------------- | ------------- | -------------|
| **status** | [**List&lt;String&gt;**](String.md)| Status values that need to be considered for filter | [enum: available, pending, sold] |

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P3: The status parameter on poniesPost is marked deprecated in the OpenAPI spec but the Notes column doesn't reflect it (no [deprecated] tag). Since this is auto-generated doc, check whether the generator template handles parameter-level deprecated — if not, the generated docs will silently drop this metadata and consumers won't see it.

Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. At samples/client/petstore/java/microprofile-rest-client-3.0-jackson-ignore-case/docs/DefaultApi.md, line 118:

<comment>The `status` parameter on `poniesPost` is marked deprecated in the OpenAPI spec but the Notes column doesn't reflect it (no `[deprecated]` tag). Since this is auto-generated doc, check whether the generator template handles parameter-level `deprecated` — if not, the generated docs will silently drop this metadata and consumers won't see it.</comment>

<file context>
@@ -65,5 +68,71 @@ No authorization required
+
+| Name | Type | Description  | Notes |
+|------------- | ------------- | ------------- | -------------|
+| **status** | [**List&lt;String&gt;**](String.md)| Status values that need to be considered for filter | [enum: available, pending, sold] |
+
+### Return type
</file context>

@wing328 wing328 merged commit 6bdcf73 into master Jul 6, 2026
152 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant