Skip to content

[Golang] support multi collection serialization for query params #3559

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
andrewkav wants to merge 1 commit into from
Closed

[Golang] support multi collection serialization for query params #3559

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions modules/openapi-generator/src/main/resources/go/api.mustache
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -132,11 +132,11 @@ func (a *{{{classname}}}Service) {{{nickname}}}(ctx context.Context{{#hasParams}
{{#hasQueryParams}}
{{#queryParams}}
{{#required}}
localVarQueryParams.Add("{{baseName}}", parameterToString({{paramName}}, "{{#collectionFormat}}{{collectionFormat}}{{/collectionFormat}}"))
localVarQueryParams = addQueryParams(localVarQueryParams, "{{baseName}}", {{paramName}}, "{{#collectionFormat}}{{collectionFormat}}{{/collectionFormat}}")
{{/required}}
{{^required}}
if localVarOptionals != nil && localVarOptionals.{{vendorExtensions.x-exportParamName}}.IsSet() {
localVarQueryParams.Add("{{baseName}}", parameterToString(localVarOptionals.{{vendorExtensions.x-exportParamName}}.Value(), "{{#collectionFormat}}{{collectionFormat}}{{/collectionFormat}}"))
localVarQueryParams = addQueryParams(localVarQueryParams, "{{baseName}}", localVarOptionals.{{vendorExtensions.x-exportParamName}}.Value(), "{{#collectionFormat}}{{collectionFormat}}{{/collectionFormat}}")
}
{{/required}}
{{/queryParams}}
Expand Down
15 changes: 15 additions & 0 deletions modules/openapi-generator/src/main/resources/go/client.mustache
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -111,6 +111,21 @@ func contains(haystack []string, needle string) bool {
return false
}

// addQueryParams adds a query params depending on collectionFormat
// if collectionFormat == "multi" it will add multiple entries to query string e.g.
// ["q1", "q2, "q3"] will be converted to `paramName=q1&paramName=q2&paramName=q3`
func addQueryParams(q url.Values, paramName string, paramValue interface{}, collectionFormat string) url.Values {
if collectionFormat == "multi" && reflect.TypeOf(paramValue).Kind() == reflect.Slice {
paramSlice := reflect.ValueOf(paramValue)

for i := 0; i < paramSlice.Len(); i++ {
q.Add(paramName, parameterToString(paramSlice.Index(i).Interface(), ""))
}
}
q.Add(paramName, parameterToString(paramValue, collectionFormat))
return q
}

// Verify optional parameters are of the correct type.
func typeCheckParameter(obj interface{}, expected string, name string) error {
// Make sure there is an object.
Expand Down