Skip to content

[typescript-rxjs] improve HttpQuery typing#4198

Merged
macjohnny merged 2 commits into
OpenAPITools:masterfrom
denyo:feature/http-query-typing
Oct 21, 2019
Merged

[typescript-rxjs] improve HttpQuery typing#4198
macjohnny merged 2 commits into
OpenAPITools:masterfrom
denyo:feature/http-query-typing

Conversation

@denyo

@denyo denyo commented Oct 21, 2019

Copy link
Copy Markdown
Contributor

Refactoring of #4160.

PR checklist

  • Read the contribution guidelines.
  • If contributing template-only or documentation-only changes which will change sample output, build the project before .
  • Run the shell script(s) under ./bin/ (or Windows batch scripts under.\bin\windows) to update Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit, and these must match the expectations made by your contribution. You only need to run ./bin/{LANG}-petstore.sh, ./bin/openapi3/{LANG}-petstore.sh if updating the code or mustache templates for a language ({LANG}) (e.g. php, ruby, python, etc).
  • File the PR against the correct branch: master, 4.1.x, 5.0.x. Default: master.
  • Copy the technical committee to review the pull request if your PR is targeting a particular programming language.

@TiFu (2017/07) @taxpon (2017/07) @sebastianhaas (2017/07) @kenisteward (2017/07) @Vrolijkx (2017/09) @macjohnny (2018/01) @nicokoenig (2018/09) @topce (2018/10) @akehir (2019/07)

@auto-labeler

auto-labeler Bot commented Oct 21, 2019

Copy link
Copy Markdown

👍 Thanks for opening this issue!
🏷 I have applied any labels matching special text in your issue.

The team will review the labels and make any necessary changes.

@macjohnny macjohnny left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@macjohnny macjohnny merged commit ea76a94 into OpenAPITools:master Oct 21, 2019
@denyo denyo deleted the feature/http-query-typing branch October 23, 2019 17:40
@wing328 wing328 added this to the 4.2.0 milestone Oct 30, 2019
@wing328

wing328 commented Oct 31, 2019

Copy link
Copy Markdown
Member

@denyo thanks for the PR, which has been included in v4.2.0 release: https://twitter.com/oas_generator/status/1189824932345069569

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants