Skip to content

Fix conflict if paramName is data#4266

Merged
wing328 merged 2 commits into
OpenAPITools:masterfrom
lingster:master
Oct 26, 2019
Merged

Fix conflict if paramName is data#4266
wing328 merged 2 commits into
OpenAPITools:masterfrom
lingster:master

Conversation

@lingster

Copy link
Copy Markdown
Contributor

If a the paramName inside a swagger doc is called data then the generated code does not compile.

PR checklist

  • [ Y] Read the contribution guidelines.
  • [ Y] If contributing template-only or documentation-only changes which will change sample output, build the project before.
  • [ Y] Run the shell script(s) under ./bin/ (or Windows batch scripts under.\bin\windows) to update Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit, and these must match the expectations made by your contribution. You only need to run ./bin/{LANG}-petstore.sh, ./bin/openapi3/{LANG}-petstore.sh if updating the code or mustache templates for a language ({LANG}) (e.g. php, ruby, python, etc).
  • [Y ] File the PR against the correct branch: master, 4.1.x, 5.0.x. Default: master.
  • [Y ] Copy the technical committee to review the pull request if your PR is targeting a particular programming language.

@wing328

wing328 commented Oct 26, 2019

Copy link
Copy Markdown
Member

Shippable issue already resolved in the master

@wing328

wing328 commented Oct 26, 2019

Copy link
Copy Markdown
Member

@lingster thanks for the PR. We can go with your fix but later I may file a PR to add localVar as a prefix to all local variables.

@wing328 wing328 merged commit 2d2a266 into OpenAPITools:master Oct 26, 2019
@wing328 wing328 added this to the 4.2.0 milestone Oct 26, 2019
@lingster

Copy link
Copy Markdown
Contributor Author

@wing328 thabks for merging, PR for localvar for all local variables makes sense

@wing328 wing328 changed the title Fix conflict if swagger paramName is data Fix conflict if paramName is data Oct 30, 2019
@wing328

wing328 commented Oct 31, 2019

Copy link
Copy Markdown
Member

@lingster thanks for the PR, which has been included in v4.2.0 release: https://twitter.com/oas_generator/status/1189824932345069569

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants