Skip to content

[Scala][Finch] use Files.createTempFile to avoid potential security issues #8791

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
wing328 merged 1 commit into from
Feb 23, 2021
Merged

[Scala][Finch] use Files.createTempFile to avoid potential security issues #8791

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion modules/openapi-generator/src/main/resources/scala-finch/api.mustache
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@ import com.twitter.util.Future
import com.twitter.io.Buf
import io.finch._, items._
import java.io.File
import java.nio.file.Files
import java.time._

object {{classname}} {
Expand Down Expand Up @@ -81,7 +82,7 @@ object {{classname}} {
}

private def bytesToFile(input: Array[Byte]): java.io.File = {
val file = File.createTempFile("tmp{{classname}}", null)
val file = Files.createTempFile("tmp{{classname}}", null).toFile
val output = new FileOutputStream(file)
output.write(input)
file
Expand Down
3 changes: 2 additions & 1 deletion samples/server/petstore/scala-finch/src/main/scala/org/openapitools/apis/PetApi.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@ import com.twitter.util.Future
import com.twitter.io.Buf
import io.finch._, items._
import java.io.File
import java.nio.file.Files
import java.time._

object PetApi {
Expand Down Expand Up @@ -179,7 +180,7 @@ object PetApi {
}

private def bytesToFile(input: Array[Byte]): java.io.File = {
val file = File.createTempFile("tmpPetApi", null)
val file = Files.createTempFile("tmpPetApi", null).toFile
val output = new FileOutputStream(file)
output.write(input)
file
Expand Down
3 changes: 2 additions & 1 deletion samples/server/petstore/scala-finch/src/main/scala/org/openapitools/apis/StoreApi.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@ import com.twitter.util.Future
import com.twitter.io.Buf
import io.finch._, items._
import java.io.File
import java.nio.file.Files
import java.time._

object StoreApi {
Expand Down Expand Up @@ -117,7 +118,7 @@ object StoreApi {
}

private def bytesToFile(input: Array[Byte]): java.io.File = {
val file = File.createTempFile("tmpStoreApi", null)
val file = Files.createTempFile("tmpStoreApi", null).toFile
val output = new FileOutputStream(file)
output.write(input)
file
Expand Down
3 changes: 2 additions & 1 deletion samples/server/petstore/scala-finch/src/main/scala/org/openapitools/apis/UserApi.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@ import com.twitter.util.Future
import com.twitter.io.Buf
import io.finch._, items._
import java.io.File
import java.nio.file.Files
import java.time._

object UserApi {
Expand Down Expand Up @@ -178,7 +179,7 @@ object UserApi {
}

private def bytesToFile(input: Array[Byte]): java.io.File = {
val file = File.createTempFile("tmpUserApi", null)
val file = Files.createTempFile("tmpUserApi", null).toFile
val output = new FileOutputStream(file)
output.write(input)
file
Expand Down