Skip to content

C# - nullable string#9234

Closed
gbmarc1 wants to merge 1 commit into
OpenAPITools:masterfrom
gbmarc1:bug-string-not-in-nullable-type
Closed

C# - nullable string#9234
gbmarc1 wants to merge 1 commit into
OpenAPITools:masterfrom
gbmarc1:bug-string-not-in-nullable-type

Conversation

@gbmarc1

@gbmarc1 gbmarc1 commented Apr 11, 2021

Copy link
Copy Markdown
Contributor

Make string a nullable type.

Useful for optional query param

#9233

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh
    ./bin/utils/export_docs_generators.sh
    
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    For Windows users, please run the script in Git BASH.
  • File the PR against the correct branch: master, 5.1.x, 6.0.x
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@gbmarc1

gbmarc1 commented Apr 11, 2021

Copy link
Copy Markdown
Contributor Author

Mentioning technical committee
@mandrean @frankyjuang @shibayan @Blackclaws

@gbmarc1 gbmarc1 changed the title nullable string C# - nullable string Apr 11, 2021
@devhl-labs

devhl-labs commented Apr 12, 2021

Copy link
Copy Markdown
Contributor

I think it requires a bit more than what you've changed. I added an option for NRT here #9235. I don't mean to swoop in right after your pr, but I started this work a few weeks ago and was asked to split the option out from other work. Just took time to get to it.

@gbmarc1

gbmarc1 commented Apr 15, 2021

Copy link
Copy Markdown
Contributor Author

@devhl-labs Do you think it would be better for me to work on this PR after your's is completed?

@devhl-labs

Copy link
Copy Markdown
Contributor

Yes, of course. Or you can clone my branch and see if it helps fix your problem.

@wing328

wing328 commented Jun 18, 2021

Copy link
Copy Markdown
Member

Closed per #9234 (comment)

@wing328 wing328 closed this Jun 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants