Skip to content

[aspnetcore] Fix incorrect logging messages#9405

Merged
wing328 merged 2 commits into
OpenAPITools:masterfrom
hauntingEcho:patch-2
May 6, 2021
Merged

[aspnetcore] Fix incorrect logging messages#9405
wing328 merged 2 commits into
OpenAPITools:masterfrom
hauntingEcho:patch-2

Conversation

@hauntingEcho

Copy link
Copy Markdown
Contributor

PR checklist

  • [ X ] Read the contribution guidelines.
  • [ X ] Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • [ X ] Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh
    ./bin/utils/export_docs_generators.sh
    
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    For Windows users, please run the script in Git BASH.
  • [ X ] File the PR against the correct branch: master, 5.1.x, 6.0.x
  • [ X ] If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request. - @mandrean @frankyjuang @shibayan @Blackclaws

private void setBuildTarget() {
setCliOption(buildTarget);
if ("library".equals(buildTarget.getOptValue())) {
LOGGER.warn("buildTarget is " + buildTarget.getOptValue() + " so changing default isLibrary to true ");

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggestion:

LOGGER.warn("buildTarget is {} so changing default isLibrary to true",  buildTarget.getOptValue());

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed 4fc83c6

private void setUseSwashbuckle() {
if (isLibrary) {
LOGGER.warn("buildTarget is " + buildTarget.getOptValue() + " so changing default isLibrary to false ");
LOGGER.warn("isLibrary is true so changing default useSwashbuckle to false ");

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggestion: removing the trailing whitespace.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed 4fc83c6

cleans up log messages
@wing328 wing328 changed the title fix incorrect aspnetcore logging messages [aspnetcore] Fix incorrect logging messages May 6, 2021
@wing328 wing328 added this to the 5.1.1 milestone May 6, 2021
@wing328

wing328 commented May 6, 2021

Copy link
Copy Markdown
Member

LGTM

@wing328 wing328 merged commit 45d55f6 into OpenAPITools:master May 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants