Skip to content

Uncomment the status.isNullable test in RubyClientCodegenTest.java since #820 is now solved in swagger-parser #981

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ndbroadbent wants to merge 2 commits into from
Closed

Uncomment the status.isNullable test in RubyClientCodegenTest.java since #820 is now solved in swagger-parser #981

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
696596c
Update swagger-parser-version to 2.0.4
ndbroadbent Sep 6, 2018
26f15f5
Uncomment the status.isNullable test in RubyClientCodegenTest.java si…
ndbroadbent Sep 6, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion CI/pom.xml.bash
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -920,7 +920,7 @@
</repository>
</repositories>
<properties>
<swagger-parser-version>2.0.3-OpenAPITools.org-1</swagger-parser-version>
<swagger-parser-version>2.0.4-OpenAPITools.org-1</swagger-parser-version>
<swagger-core-version>2.0.1</swagger-core-version>
<scala-version>2.11.1</scala-version>
<felix-version>3.3.0</felix-version>
Expand Down
2 changes: 1 addition & 1 deletion CI/pom.xml.circleci
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1030,7 +1030,7 @@
</repository>
</repositories>
<properties>
<swagger-parser-version>2.0.3-OpenAPITools.org-1</swagger-parser-version>
<swagger-parser-version>2.0.4-OpenAPITools.org-1</swagger-parser-version>
<swagger-core-version>2.0.1</swagger-core-version>
<scala-version>2.11.1</scala-version>
<felix-version>3.3.0</felix-version>
Expand Down
2 changes: 1 addition & 1 deletion CI/pom.xml.circleci.java7
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1000,7 +1000,7 @@
</repository>
</repositories>
<properties>
<swagger-parser-version>2.0.3-OpenAPITools.org-1</swagger-parser-version>
<swagger-parser-version>2.0.4-OpenAPITools.org-1</swagger-parser-version>
<swagger-core-version>2.0.1</swagger-core-version>
<scala-version>2.11.1</scala-version>
<felix-version>3.3.0</felix-version>
Expand Down
2 changes: 1 addition & 1 deletion CI/pom.xml.ios
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -928,7 +928,7 @@
</repository>
</repositories>
<properties>
<swagger-parser-version>2.0.3-OpenAPITools.org-1</swagger-parser-version>
<swagger-parser-version>2.0.4-OpenAPITools.org-1</swagger-parser-version>
<swagger-core-version>2.0.1</swagger-core-version>
<scala-version>2.11.1</scala-version>
<felix-version>3.3.0</felix-version>
Expand Down
4 changes: 2 additions & 2 deletions modules/openapi-generator/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -203,11 +203,11 @@
<artifactId>swagger-core</artifactId>
<version>${swagger-core-version}</version>
</dependency>
<dependency>
<dependency>
<groupId>org.openapitools.swagger.parser</groupId>
<artifactId>swagger-parser</artifactId>
<version>${swagger-parser-version}</version>
</dependency>
</dependency>
<dependency>
<groupId>com.samskivert</groupId>
<artifactId>jmustache</artifactId>
Expand Down
3 changes: 1 addition & 2 deletions .../openapi-generator/src/test/java/org/openapitools/codegen/ruby/RubyClientCodegenTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -268,7 +268,6 @@ public void nullableParameterOAS2Test() {
CodegenParameter name = op.formParams.get(0);
Assert.assertFalse(name.isNullable);
CodegenParameter status = op.formParams.get(1);
// TODO comment out the following until https://github.com/swagger-api/swagger-parser/issues/820 is solved
//Assert.assertTrue(status.isNullable);
Assert.assertTrue(status.isNullable);
}
}
2 changes: 1 addition & 1 deletion pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1147,7 +1147,7 @@
<properties>
<maven.compiler.source>1.8</maven.compiler.source>
<maven.compiler.target>1.8</maven.compiler.target>
<swagger-parser-version>2.0.3-OpenAPITools.org-1</swagger-parser-version>
<swagger-parser-version>2.0.4-OpenAPITools.org-1</swagger-parser-version>
<swagger-core-version>2.0.1</swagger-core-version>
<scala-version>2.11.1</scala-version>
<felix-version>3.3.0</felix-version>
Expand Down