ci: disambiguate the two release-please PR titles - #430
Merged
Conversation
The two release PRs were indistinguishable: both titled "chore: release
<version>", differing only in a version number that does not say which
component it belongs to. Give the pkg/etl one a scope so the list reads:
chore: release 1.8.3
chore(pkg/etl): release 1.6.3
Neither ${scope} nor ${component} can supply this. ${scope} interpolates the
target branch, not the component, so it would render "chore(main):"; and
${component} carries a leading space unless component-no-space is set. Hence
the literal scope on the one package that needs it — the root title is
unchanged.
The shared header also claimed that merging "cuts a new release and promotes
:stable", which is true of the root PR and false of the pkg/etl one, whose
tag matches neither tag-released.yml nor buf-publish.yml (both gated on
tags: ['v*'], and a ref filter's * does not match /). Corrected to one
sentence covering both.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
rickyrombo
force-pushed
the
ci/release-please-disambiguate
branch
from
August 4, 2026 21:37
e7302e4 to
2997581
Compare
rickyrombo
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The two release PRs are indistinguishable in the list:
Same shape, differing only in a version number that doesn't say which component it belongs to. And since
pull-request-headerwas set at the top level, both claimed "Merging this PR cuts a new release and promotes:stable" — true of #427, false of #423, and wrong in the direction that makes the safe PR look risky.Change
Two lines.
Plus one accurate sentence in the shared header.
Why a literal scope rather than a placeholder
Neither built-in placeholder works here:
${scope}interpolates the target branch, not the component — it would renderchore(main): release 1.8.3.${component}carries a leading space unlesscomponent-no-spaceis set —chore( pkg/etl):.So the scope is written literally on the one package that needs it. The root title is untouched.
Verification of the header claim
pkg/etltags arepkg/etl/vX.Y.Z, which match neithertag-released.ymlnorbuf-publish.yml— both gated ontags: ['v*'], and a GitHub ref filter's*does not match/. Confirmed empirically:tag-released.ymlhas run 9 times, all on root tags, and no push-event run in the repo's history has ever been triggered by apkg/etlref, across 6 such tags.:stable's digest is identical to:v1.8.2's.🤖 Generated with Claude Code