Feature repulsive morse#435
Merged
lohedges merged 4 commits intoOpenBioSim:develfrom Apr 21, 2026
Merged
Conversation
Contributor
|
Thanks. No worries about the CHANGELOG. Since DMR was only added as part of this development cycle this addition can be absorbed into the original entry. |
lohedges
approved these changes
Apr 21, 2026
Contributor
lohedges
left a comment
There was a problem hiding this comment.
Thanks for adding this, and for the detailed investigation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes proposed in this pull request:
This PR introduces a repulsion term to the Morse potential. See the internal discussion for details. I haven't updated the change log entry yet as I am submitting this PR from my phone (can do that later in the day)
develinto this branch before issuing this pull request (e.g. by runninggit pull origin devel): y