Histograms from timestamps#117
Closed
rettigl wants to merge 1 commit into
Closed
Conversation
Member
Author
Member
Author
|
The current implementation still suffers from the bin-centers vs. bin-edges problem, I think. Needs further inspection. |
rettigl
force-pushed
the
histograms_from_timestamps
branch
from
dd368fe to
9330a48
Compare
Member
Author
|
This looks promising now, but is still rather slow. |
Member
Author
|
Closing this, as it is implemented in PR #116 as well, and thus obsolete |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds histogram calculation based on the timeStamp column in the dataframe
Histogram calculation in the example notebook takes on our machine close to 2 minutes. Additionally, binning becomes slower when timeStamps are generated, even if they are not used during binning.