[frontend] Fix logo not following user's selected theme (#14435)#14689
[frontend] Fix logo not following user's selected theme (#14435)#14689SamuelHassine merged 2 commits intomasterfrom
Conversation
|
Thank you for your contribution, but we need you to sign your commits. Please see https://docs.github.com/en/authentication/managing-commit-signature-verification/signing-commits |
1 similar comment
|
Thank you for your contribution, but we need you to sign your commits. Please see https://docs.github.com/en/authentication/managing-commit-signature-verification/signing-commits |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #14689 +/- ##
=======================================
Coverage 32.37% 32.37%
=======================================
Files 3098 3098
Lines 211019 211018 -1
Branches 38241 38241
=======================================
Hits 68310 68310
+ Misses 142709 142708 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
97ff62b to
651d1d3
Compare
|
Please attach at least one issue to your Pull Request |
2 similar comments
|
Please attach at least one issue to your Pull Request |
|
Please attach at least one issue to your Pull Request |
Co-authored-by: SamuelHassine <1334279+SamuelHassine@users.noreply.github.com>
651d1d3 to
fdd3df1
Compare
|
Working well :) |
When users configure different logos for dark and light themes and select a theme in their profile settings, the displayed logo follows the platform default theme instead of the user's selected theme.
Root Cause
The LeftBar component queries
platform_themedirectly from GraphQL and uses its logos, bypassing the theme resolution system that determines the user's active theme.Changes
LeftBar.jsx
platform_theme.theme_logoandplatform_theme.theme_logo_collapsedtheme.logoandtheme.logo_collapsedfrom the MUI theme object, which already contains logos from the user's active theme via theuseActiveTheme→AppThemeProvider→ThemeDark/ThemeLightflowThe theme object is already populated with the correct logos based on user preference in
Root.tsx→useActiveTheme→AppThemeProvider, so LeftBar should use it directly rather than re-querying platform settings.Original prompt