Skip to content

[backend] Split playbook components into separated files (#14283)#14728

Merged
MTorbay-Filigran merged 13 commits intomasterfrom
issue/14283-split-components
Mar 4, 2026
Merged

[backend] Split playbook components into separated files (#14283)#14728
MTorbay-Filigran merged 13 commits intomasterfrom
issue/14283-split-components

Conversation

@MTorbay-Filigran
Copy link
Member

@MTorbay-Filigran MTorbay-Filigran commented Mar 3, 2026

Proposed changes

  • Split the listed components of 14283 issue in separated files

Related issues

Checklist

  • I consider the submitted work as finished
  • I tested the code for its functionality
  • I wrote test cases for the relevant uses case (coverage and e2e)
  • I added/update the relevant documentation (either on github or on notion)
  • Where necessary I refactored code to improve the overall quality

Further comments

@codecov
Copy link

codecov bot commented Mar 3, 2026

Codecov Report

❌ Patch coverage is 66.63844% with 394 lines in your changes missing coverage. Please review.
✅ Project coverage is 32.37%. Comparing base (a6b1545) to head (c459abd).
⚠️ Report is 11 commits behind head on master.

Files with missing lines Patch % Lines
.../playbook/components/create-indicator-component.ts 19.67% 196 Missing ⚠️
...playbook/components/create-observable-component.ts 25.38% 97 Missing ⚠️
...playbook/components/security-coverage-component.ts 48.62% 56 Missing ⚠️
...playbook/components/container-wrapper-component.ts 74.12% 37 Missing ⚠️
...ybook/components/manipulate-knowledge-component.ts 97.77% 5 Missing ⚠️
...aybook/components/access-restrictions-component.ts 97.58% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master   #14728      +/-   ##
==========================================
- Coverage   32.38%   32.37%   -0.01%     
==========================================
  Files        3098     3107       +9     
  Lines      211071   213278    +2207     
  Branches    38242    38420     +178     
==========================================
+ Hits        68345    69044     +699     
- Misses     142726   144234    +1508     
Flag Coverage Δ
opencti-client-python 42.58% <ø> (-3.00%) ⬇️
opencti-front 2.82% <ø> (-0.01%) ⬇️
opencti-graphql 67.83% <66.63%> (+0.09%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@SouadHadjiat SouadHadjiat added the filigran team use to identify PR from the Filigran team label Mar 4, 2026
}

export const PLAYBOOK_MANIPULATE_KNOWLEDGE_COMPONENT: PlaybookComponent<ManipulateConfiguration> = {
id: 'PLAYBOOK_MANIPULATE_KNOWLEDGE_COMPONENT',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This component id has been renamed from PLAYBOOK_UPDATE_KNOWLEDGE_COMPONENT to PLAYBOOK_MANIPULATE_KNOWLEDGE_COMPONENT. We can't rename component ids, otherwise all previously created playbooks with this component will fail, and we would need to migrate them.

Copy link
Member

@SouadHadjiat SouadHadjiat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

keep the component ids the same as before the refactoring

@MTorbay-Filigran MTorbay-Filigran self-assigned this Mar 4, 2026
@MTorbay-Filigran MTorbay-Filigran marked this pull request as ready for review March 4, 2026 10:59
@MTorbay-Filigran MTorbay-Filigran merged commit aefc31d into master Mar 4, 2026
54 checks passed
@MTorbay-Filigran MTorbay-Filigran deleted the issue/14283-split-components branch March 4, 2026 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

filigran team use to identify PR from the Filigran team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants