Skip to content

[frontend] fix security menu redirections(#14736)#14759

Merged
CelineSebe merged 1 commit intomasterfrom
issue/14736
Mar 4, 2026
Merged

[frontend] fix security menu redirections(#14736)#14759
CelineSebe merged 1 commit intomasterfrom
issue/14736

Conversation

@CelineSebe
Copy link
Member

@CelineSebe CelineSebe commented Mar 4, 2026

Proposed changes

*Expands access to the ‘Security’ root of the settings and adds a redirect to the appropriate Security subpage based on the permissions granted

Related issues

Checklist

  • I consider the submitted work as finished
  • I tested the code for its functionality
  • I wrote test cases for the relevant uses case (coverage and e2e)
  • I added/update the relevant documentation (either on github or on notion)
  • Where necessary I refactored code to improve the overall quality

Further comments

@github-actions github-actions bot added the filigran team use to identify PR from the Filigran team label Mar 4, 2026
@CelineSebe CelineSebe changed the title [frontend] fix security menu redirections [frontend] fix security menu redirections(#14736) Mar 4, 2026
@codecov
Copy link

codecov bot commented Mar 4, 2026

Codecov Report

❌ Patch coverage is 0% with 19 lines in your changes missing coverage. Please review.
✅ Project coverage is 32.36%. Comparing base (4a42577) to head (e7b4abd).
⚠️ Report is 3 commits behind head on master.

Files with missing lines Patch % Lines
...cti-front/src/private/components/settings/Root.tsx 0.00% 18 Missing ⚠️
...encti-front/src/private/components/nav/LeftBar.jsx 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master   #14759      +/-   ##
==========================================
- Coverage   32.37%   32.36%   -0.01%     
==========================================
  Files        3098     3098              
  Lines      211033   211049      +16     
  Branches    38245    38250       +5     
==========================================
+ Hits        68312    68315       +3     
- Misses     142721   142734      +13     
Flag Coverage Δ
opencti-client-python 45.48% <ø> (ø)
opencti-front 2.83% <0.00%> (-0.01%) ⬇️
opencti-graphql 67.74% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@CelineSebe CelineSebe marked this pull request as ready for review March 4, 2026 10:53
@CelineSebe CelineSebe requested a review from Copilot March 4, 2026 13:35
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Fixes the Settings → Security menu redirection so users with any security-related capability (markings, dissemination lists, authentications, org admin, etc.) land on an appropriate Security subpage instead of being bounced back to Parameters.

Changes:

  • Update the /dashboard/settings/accesses route guard to allow additional security-related capabilities (markings, dissemination, auth).
  • Add a capability-aware redirect component to send users to the first Security subpage they can access.
  • Update the left navigation permission checks so the “Security” entry is shown for the same broader set of capabilities.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
opencti-platform/opencti-front/src/private/components/settings/Root.tsx Broadens access to the Settings “Security” root route and adds a redirect to the correct Security subpage based on granted capabilities.
opencti-platform/opencti-front/src/private/components/nav/LeftBar.jsx Aligns the left navigation “Security” visibility and Settings section gating with the expanded security-related capabilities.

@CelineSebe CelineSebe merged commit efdef97 into master Mar 4, 2026
57 of 58 checks passed
@CelineSebe CelineSebe deleted the issue/14736 branch March 4, 2026 14:24
@CelineSebe CelineSebe linked an issue Mar 4, 2026 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

filigran team use to identify PR from the Filigran team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Can't access the setting>security page

3 participants