Skip to content

[backend] fix Remote_logout following authentication conversion (#14756)#14776

Merged
xfournet merged 3 commits intomasterfrom
issue/14756
Mar 4, 2026
Merged

[backend] fix Remote_logout following authentication conversion (#14756)#14776
xfournet merged 3 commits intomasterfrom
issue/14756

Conversation

@CelineSebe
Copy link
Member

@CelineSebe CelineSebe commented Mar 4, 2026

Proposed changes

  • Improvement of the get function for Boolean data

Related issues

Checklist

  • I consider the submitted work as finished
  • I tested the code for its functionality
  • I wrote test cases for the relevant uses case (coverage and e2e)
  • I added/update the relevant documentation (either on github or on notion)
  • Where necessary I refactored code to improve the overall quality

Further comments

@github-actions github-actions bot added the filigran team use to identify PR from the Filigran team label Mar 4, 2026
@CelineSebe CelineSebe marked this pull request as ready for review March 4, 2026 15:50
@codecov
Copy link

codecov bot commented Mar 4, 2026

Codecov Report

❌ Patch coverage is 88.88889% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 32.63%. Comparing base (efdef97) to head (f54fa1d).
⚠️ Report is 10 commits behind head on master.

Files with missing lines Patch % Lines
...ider/authenticationProvider-migration-converter.ts 88.88% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master   #14776      +/-   ##
==========================================
+ Coverage   32.36%   32.63%   +0.26%     
==========================================
  Files        3098     3107       +9     
  Lines      211049   213204    +2155     
  Branches    38249    38687     +438     
==========================================
+ Hits        68312    69582    +1270     
- Misses     142737   143622     +885     
Flag Coverage Δ
opencti-client-python 45.48% <ø> (ø)
opencti-front 2.81% <ø> (-0.02%) ⬇️
opencti-graphql 67.90% <88.88%> (+0.15%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@CelineSebe CelineSebe self-assigned this Mar 4, 2026
@xfournet xfournet merged commit 26395fd into master Mar 4, 2026
39 checks passed
@xfournet xfournet deleted the issue/14756 branch March 4, 2026 22:01
@RBourgeoisGH RBourgeoisGH changed the title [backend] fix conversion error during local strategy conversion(#14756) [backend] fix Remote_lougout following authentication conversion (#14756) Mar 5, 2026
@RBourgeoisGH RBourgeoisGH changed the title [backend] fix Remote_lougout following authentication conversion (#14756) [backend] fix Remote_logout following authentication conversion (#14756) Mar 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

filigran team use to identify PR from the Filigran team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Authentication] Conversion error during local strategy conversion

3 participants