Skip to content

[backend] fix migration for local strategy (#14737)#14790

Merged
marieflorescontact merged 6 commits intomasterfrom
issue/14737
Mar 9, 2026
Merged

[backend] fix migration for local strategy (#14737)#14790
marieflorescontact merged 6 commits intomasterfrom
issue/14737

Conversation

@marieflorescontact
Copy link
Member

@marieflorescontact marieflorescontact commented Mar 5, 2026

Proposed changes

  • for an existing platform in 6.9.x, with local auth disabled => conversion set it to enabled, probably because it's config { disabled: true } and code looks for enabled here

Related issues

Checklist

  • I consider the submitted work as finished
  • I tested the code for its functionality
  • I wrote test cases for the relevant uses case (coverage and e2e)
  • I added/update the relevant documentation (either on github or on notion)
  • Where necessary I refactored code to improve the overall quality

Further comments

@marieflorescontact marieflorescontact added the filigran team use to identify PR from the Filigran team label Mar 5, 2026
@marieflorescontact
Copy link
Member Author

@copilot add test coverage for this PR

Copy link
Contributor

Copilot AI commented Mar 5, 2026

@marieflorescontact I've opened a new pull request, #14791, to work on those changes. Once the pull request is ready, I'll request review from you.

@codecov
Copy link

codecov bot commented Mar 5, 2026

Codecov Report

❌ Patch coverage is 66.66667% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 32.75%. Comparing base (820a5b0) to head (037c64b).
⚠️ Report is 34 commits behind head on master.

Files with missing lines Patch % Lines
...cationProvider/authenticationProvider-migration.ts 66.66% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master   #14790      +/-   ##
==========================================
+ Coverage   32.36%   32.75%   +0.39%     
==========================================
  Files        3107     3111       +4     
  Lines      211587   213397    +1810     
  Branches    38362    39048     +686     
==========================================
+ Hits        68472    69896    +1424     
- Misses     143115   143501     +386     
Flag Coverage Δ
opencti-client-python 44.13% <ø> (-1.35%) ⬇️
opencti-front 2.82% <ø> (-0.01%) ⬇️
opencti-graphql 68.32% <66.66%> (+0.65%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@marieflorescontact marieflorescontact marked this pull request as ready for review March 6, 2026 08:44
Copy link
Member

@aHenryJard aHenryJard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, tested locally:

  • on a new platform V7, local is enabled by default as expected
  • on an existing platform with auth0 + local disabled, after moving to this branch the local is correctly disabled (only auth0 button is displayed)

@marieflorescontact marieflorescontact merged commit 23efc77 into master Mar 9, 2026
45 checks passed
@marieflorescontact marieflorescontact deleted the issue/14737 branch March 9, 2026 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

filigran team use to identify PR from the Filigran team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Disabled local authentication strategy is set to enable following conversion to V7

3 participants