Skip to content

[backend] fix OpenIDConnect when token are not valid JWT (#14839)#14840

Merged
xfournet merged 2 commits intomasterfrom
issue/14839-oauth0-problem
Mar 6, 2026
Merged

[backend] fix OpenIDConnect when token are not valid JWT (#14839)#14840
xfournet merged 2 commits intomasterfrom
issue/14839-oauth0-problem

Conversation

@xfournet
Copy link
Member

@xfournet xfournet commented Mar 6, 2026

Proposed changes

  • when decoding token for log purpose then catch jwtDecode error, and log error instead of blocking

Related issues

Checklist

  • I consider the submitted work as finished
  • I tested the code for its functionality
  • I wrote test cases for the relevant uses case (coverage and e2e)
  • I added/update the relevant documentation (either on github or on notion)
  • Where necessary I refactored code to improve the overall quality

@xfournet xfournet self-assigned this Mar 6, 2026
@codecov
Copy link

codecov bot commented Mar 6, 2026

Codecov Report

❌ Patch coverage is 0% with 19 lines in your changes missing coverage. Please review.
✅ Project coverage is 32.37%. Comparing base (bbbd715) to head (3921796).
⚠️ Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
...rc/modules/authenticationProvider/provider-oidc.ts 0.00% 13 Missing ⚠️
...-platform/opencti-graphql/src/http/httpPlatform.js 0.00% 6 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master   #14840      +/-   ##
==========================================
- Coverage   32.37%   32.37%   -0.01%     
==========================================
  Files        3111     3111              
  Lines      211862   211878      +16     
  Branches    38414    38414              
==========================================
  Hits        68594    68594              
- Misses     143268   143284      +16     
Flag Coverage Δ
opencti-client-python 45.53% <ø> (ø)
opencti-front 2.82% <ø> (ø)
opencti-graphql 67.58% <0.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@xfournet xfournet force-pushed the issue/14839-oauth0-problem branch from 9fb403b to 3921796 Compare March 6, 2026 19:08
@xfournet xfournet merged commit 89cc714 into master Mar 6, 2026
36 checks passed
@xfournet xfournet deleted the issue/14839-oauth0-problem branch March 6, 2026 19:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

OpenIDConnect authentication fail when access token is not a JWT

2 participants