Skip to content

[frontend] fix Infinite loading of cards (#14848)#14864

Merged
CelineSebe merged 1 commit intomasterfrom
issue/14848
Mar 9, 2026
Merged

[frontend] fix Infinite loading of cards (#14848)#14864
CelineSebe merged 1 commit intomasterfrom
issue/14848

Conversation

@CelineSebe
Copy link
Member

@CelineSebe CelineSebe commented Mar 9, 2026

Proposed changes

  • ListCardContent aligned with ListLinesContent
  • componentDidMount + updateScrollElement(): find the element in the DOM, overflowY: 'auto' ou overflowY: 'scroll' and store with this.state.computedScrollElement
  • scrollElement of the WindowScroller, with a dynamic key to force re-rendering when the element changes

Related issues

Checklist

  • I consider the submitted work as finished
  • I tested the code for its functionality
  • I wrote test cases for the relevant uses case (coverage and e2e)
  • I added/update the relevant documentation (either on github or on notion)
  • Where necessary I refactored code to improve the overall quality

Further comments

@github-actions github-actions bot added the filigran team use to identify PR from the Filigran team label Mar 9, 2026
@codecov
Copy link

codecov bot commented Mar 9, 2026

Codecov Report

❌ Patch coverage is 0% with 33 lines in your changes missing coverage. Please review.
✅ Project coverage is 32.37%. Comparing base (0d5a15b) to head (5ec694f).
⚠️ Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
...ont/src/components/list_cards/ListCardsContent.jsx 0.00% 33 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master   #14864      +/-   ##
==========================================
- Coverage   32.38%   32.37%   -0.01%     
==========================================
  Files        3111     3111              
  Lines      211882   211903      +21     
  Branches    38421    38431      +10     
==========================================
  Hits        68613    68613              
- Misses     143269   143290      +21     
Flag Coverage Δ
opencti-client-python 45.53% <ø> (ø)
opencti-front 2.82% <0.00%> (-0.01%) ⬇️
opencti-graphql 67.60% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@CelineSebe CelineSebe marked this pull request as ready for review March 9, 2026 09:11
@CelineSebe CelineSebe self-assigned this Mar 9, 2026
@SouadHadjiat SouadHadjiat changed the title [frontend]fix Infinite loading of cards(#14848) [frontend]fix Infinite loading of cards (#14848) Mar 9, 2026
@SouadHadjiat SouadHadjiat self-requested a review March 9, 2026 13:03
@SouadHadjiat SouadHadjiat changed the title [frontend]fix Infinite loading of cards (#14848) [frontend] fix Infinite loading of cards (#14848) Mar 9, 2026
@CelineSebe CelineSebe merged commit a88e278 into master Mar 9, 2026
60 checks passed
@CelineSebe CelineSebe deleted the issue/14848 branch March 9, 2026 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

filigran team use to identify PR from the Filigran team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants