Skip to content

Add support for Symfony 7 - #76

Merged
johanib merged 2 commits into
mainfrom
feature/maintenance_nov_25
Nov 17, 2025
Merged

Add support for Symfony 7#76
johanib merged 2 commits into
mainfrom
feature/maintenance_nov_25

Conversation

@johanib

@johanib johanib commented Nov 6, 2025

Copy link
Copy Markdown
Contributor

Also update dev & qa tooling.

Also update dev & qa tooling.
@johanib
johanib marked this pull request as ready for review November 10, 2025 10:01
@johanib
johanib requested a review from MKodde November 10, 2025 10:01
Comment thread composer.json Outdated

@MKodde MKodde left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work again!

Suggestions:

  1. Maybe add an entry in the CHANGELOG.md?
  2. Run the ci/cd tests on PHP 8.4?

Comment thread ci/qa/phpcpd
Comment thread composer.json
Comment thread composer.json Outdated
Comment thread composer.json Outdated
Comment thread composer.json
Comment thread src/Tests/DateTimeMock.php
Comment thread ci/qa/phpstan-baseline.neon
@johanib

johanib commented Nov 11, 2025

Copy link
Copy Markdown
Contributor Author

Nice work again!

Suggestions:

  1. Maybe add an entry in the CHANGELOG.md?
  2. Run the ci/cd tests on PHP 8.4?

✔️
Also updated the readme as it was targeted at old Symfony versions.

@johanib
johanib requested a review from MKodde November 13, 2025 13:58

@MKodde MKodde left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved, with the promise that you will install the correct SAML bundle version before merging this :)

- Update changelog and readme
- Add docheader check
- reinstate phpcpd
- update composer
@johanib
johanib force-pushed the feature/maintenance_nov_25 branch from ce35aa7 to d1267d6 Compare November 17, 2025 12:08
@johanib
johanib merged commit aa3203a into main Nov 17, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants