Fix unstructured API config and update Docker setup#15
Conversation
- add UNSTRUCTURED_MEMORY_FREE_MINIMUM_MB to unstructured-api service - set MinIO access key/secret to hardcoded values - update OPENCONTEXT_CORE_URL and service names to open-context-core
- change `unstructured.base-url` to `app.unstructured.api.url` so service connects properly
There was a problem hiding this comment.
Pull Request Overview
This PR restores unstructured API functionality and updates Docker configuration for proper service setup. The changes fix configuration keys, hardcode MinIO credentials for local development, and update service references to use the correct names.
- Fixed unstructured API configuration key structure for proper application binding
- Updated service references from mock server to actual core service
- Added memory configuration for unstructured API service
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| docker-compose.yml | Added memory limit for unstructured API, hardcoded MinIO credentials, and updated service references to open-context-core |
| core/src/main/resources/application-docker.yml | Fixed unstructured API configuration structure from flat to nested property binding |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
| - MINIO_ACCESS_KEY=${MINIO_ROOT_USER:-your-minio-access-key} | ||
| - MINIO_SECRET_KEY=${MINIO_ROOT_PASSWORD:-your-minio-secret-key} | ||
| - MINIO_ACCESS_KEY=minioadmin | ||
| - MINIO_SECRET_KEY=minioadmin123! |
There was a problem hiding this comment.
Hardcoding default credentials in Docker Compose poses a security risk. Consider using environment variables or Docker secrets, especially if this configuration might be used in non-development environments.
| - MINIO_SECRET_KEY=minioadmin123! | |
| - MINIO_ACCESS_KEY=${MINIO_ACCESS_KEY} | |
| - MINIO_SECRET_KEY=${MINIO_SECRET_KEY} |
| - MINIO_ACCESS_KEY=${MINIO_ROOT_USER:-your-minio-access-key} | ||
| - MINIO_SECRET_KEY=${MINIO_ROOT_PASSWORD:-your-minio-secret-key} | ||
| - MINIO_ACCESS_KEY=minioadmin | ||
| - MINIO_SECRET_KEY=minioadmin123! |
There was a problem hiding this comment.
Hardcoding default credentials in Docker Compose poses a security risk. Consider using environment variables or Docker secrets, especially if this configuration might be used in non-development environments.
| - MINIO_SECRET_KEY=minioadmin123! | |
| - MINIO_SECRET_KEY=${MINIO_SECRET_KEY} |
Overview
Restore unstructured API functionality and update Docker configuration for smooth service setup.
Key Changes
UNSTRUCTURED_MEMORY_FREE_MINIMUM_MBtounstructured-apiOPENCONTEXT_CORE_URLand service names toopen-context-coreunstructured.base-url→app.unstructured.api.url) to ensure proper connectionThese changes ensure the application starts correctly and connects to dependencies without err