Removes emoji characters from all log messages across service classes to improve log readability and maintain professional appearance in production environments. by Yoo-SH · Pull Request #35 · OpenContextAI/open-context

Yoo-SH · 2025-08-21T16:53:45Z

Summary of Changes

This PR removes emoji characters from all log messages across service classes to improve log readability and maintain professional appearance in production environments.

Type of Change

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to not work as expected)
Documentation update
Code refactoring
Performance improvement
Test addition

Related Issues

N/A - Code cleanup improvement

Testing Instructions

Run the application and check that all log messages appear without emoji characters
Verify that log formatting remains consistent across all service classes
Confirm that log parsing works correctly in production environments

Screenshots (if applicable)

N/A - Log message changes only

Checklist

My code follows the style guidelines of this project
I have performed a self-review of my own code
I have commented my code, particularly in hard-to-understand areas
I have made corresponding changes to the documentation
My changes generate no new warnings
I have added tests that prove my fix is effective or that my feature works
New and existing unit tests pass locally with my changes

Additional Notes

This PR is part of ongoing code cleanup efforts to improve maintainability and professional appearance. The changes affect the following service classes:

FileStorageService
ChunkingService
DocumentParsingService
EmbeddingService

All emoji characters have been removed while preserving the informative log message content and structure.

- Update JavaDoc comments in controllers and services - Translate Korean log messages to English for consistency

- Remove emoji characters from all log statements across service classes

Copilot

Pull Request Overview

This pull request removes emoji characters from all log messages across service classes to improve log readability and maintain professional appearance in production environments.

Standardizes log messages by removing emojis like 📤, ✅, ❌, 🎉, 🔍, 💾, etc. from all service classes
Converts Korean log messages to English for consistency
Maintains all existing log structure and information content while improving readability

Reviewed Changes

Copilot reviewed 10 out of 10 changed files in this pull request and generated 10 comments.

Show a summary per file

File	Description
SearchService.java	Removed emojis from hybrid search log messages and converted Korean text to English
IndexingService.java	Cleaned up emojis from indexing operation logs while preserving debug information
FileStorageService.java	Removed emojis from file upload, download, and deletion logs
EmbeddingService.java	Standardized embedding generation logs by removing emoji characters
DocumentParsingService.java	Removed emojis from document parsing logs and simplified markdown processing
ContentRetrievalService.java	Cleaned up content retrieval and token processing log messages
ChunkingService.java	Removed emojis from chunking operation logs while maintaining detailed statistics
SourceController.java	Converted Korean error messages to English for consistency
SearchController.java	Converted Korean log messages to English
DocsSourceController.java	Updated API response messages from Korean to English

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

Copilot · 2025-08-21T16:55:31Z


            // Validate file
-            log.debug("📋 [UPLOAD] Step 1/5: Validating file: {}", filename);
+            log.debug(" [UPLOAD] Step 1/5: Validating file: {}", filename);


The log message has an extra space at the beginning of the string, which should be removed for consistency with other log messages.

Suggested change

log.debug(" [UPLOAD] Step 1/5: Validating file: {}", filename);

log.debug("[UPLOAD] Step 1/5: Validating file: {}", filename);

Copilot · 2025-08-21T16:55:31Z


                long duration = System.currentTimeMillis() - startTime;
-                log.info("🎉 [UPLOAD] File upload completed successfully: id={}, filename={}, duration={}ms", 
+                log.info(" [UPLOAD] File upload completed successfully: id={}, filename={}, duration={}ms", 


The log message has an extra space at the beginning of the string, which should be removed for consistency with other log messages.

Suggested change

log.info(" [UPLOAD] File upload completed successfully: id={}, filename={}, duration={}ms",

log.info("[UPLOAD] File upload completed successfully: id={}, filename={}, duration={}ms",

Copilot · 2025-08-21T16:55:32Z


                    minioClient.makeBucket(makeBucketArgs);
-                    log.info("☁️ [MINIO] Created MinIO bucket: {}", minioConfig.getBucketName());
+                    log.info(" [MINIO] Created MinIO bucket: {}", minioConfig.getBucketName());


The log message has an extra space at the beginning of the string, which should be removed for consistency with other log messages.

Suggested change

log.info(" [MINIO] Created MinIO bucket: {}", minioConfig.getBucketName());

log.info("[MINIO] Created MinIO bucket: {}", minioConfig.getBucketName());

Copilot · 2025-08-21T16:55:32Z

        @Transactional(readOnly = true)
        public SourceDocument getDocument(UUID documentId) {
-            log.debug("📖 [QUERY] Retrieving document: id={}", documentId);
+            log.debug(" [QUERY] Retrieving document: id={}", documentId);


The log message has an extra space at the beginning of the string, which should be removed for consistency with other log messages.

Suggested change

log.debug(" [QUERY] Retrieving document: id={}", documentId);

log.debug("[QUERY] Retrieving document: id={}", documentId);

Copilot · 2025-08-21T16:55:32Z

        @Transactional(readOnly = true)
        public Page<SourceDocumentDto> getAllDocuments(Pageable pageable) {
-            log.debug("📖 [QUERY] Retrieving documents with pagination: page={}, size={}", 
+            log.debug(" [QUERY] Retrieving documents with pagination: page={}, size={}", 


The log message has an extra space at the beginning of the string, which should be removed for consistency with other log messages.

Suggested change

log.debug(" [QUERY] Retrieving documents with pagination: page={}, size={}",

log.debug("[QUERY] Retrieving documents with pagination: page={}, size={}",

Copilot · 2025-08-21T16:55:32Z

                        document.updateIngestionStatus(status);
                        sourceDocumentRepository.save(document);
-                        log.info("📝 [STATUS] Document status updated: id={}, status={}", documentId, status);
+                        log.info(" [STATUS] Document status updated: id={}, status={}", documentId, status);


The log message has an extra space at the beginning of the string, which should be removed for consistency with other log messages.

Suggested change

log.info(" [STATUS] Document status updated: id={}, status={}", documentId, status);

log.info("[STATUS] Document status updated: id={}, status={}", documentId, status);

Copilot · 2025-08-21T16:55:33Z

                        document.updateIngestionStatus(IngestionStatus.COMPLETED);
                        sourceDocumentRepository.save(document);
-                        log.info("🎉 [STATUS] Document status updated to COMPLETED: id={}", documentId);
+                        log.info(" [STATUS] Document status updated to COMPLETED: id={}", documentId);


The log message has an extra space at the beginning of the string, which should be removed for consistency with other log messages.

Suggested change

log.info(" [STATUS] Document status updated to COMPLETED: id={}", documentId);

log.info("[STATUS] Document status updated to COMPLETED: id={}", documentId);

Copilot · 2025-08-21T16:55:33Z

            IngestionStatus status = document.getIngestionStatus();

-            log.info("📝 [DELETE] Document details: filename={}, status={}, size={} bytes", 
+            log.info(" [DELETE] Document details: filename={}, status={}, size={} bytes", 


The log message has an extra space at the beginning of the string, which should be removed for consistency with other log messages.

Suggested change

log.info(" [DELETE] Document details: filename={}, status={}, size={} bytes",

log.info("[DELETE] Document details: filename={}, status={}, size={} bytes",

Copilot · 2025-08-21T16:55:33Z

            // Check if document is currently being processed (but allow DELETING status)
            if (document.isProcessing() && status != IngestionStatus.DELETING) {
-                log.warn("⚠️ [DELETE] Cannot delete document in processing state: id={}, status={}", 
+                log.warn(" [DELETE] Cannot delete document in processing state: id={}, status={}", 


The log message has an extra space at the beginning of the string, which should be removed for consistency with other log messages.

Suggested change

log.warn(" [DELETE] Cannot delete document in processing state: id={}, status={}",

log.warn("[DELETE] Cannot delete document in processing state: id={}, status={}",

Yoo-SH added 2 commits August 22, 2025 01:27

chore: translate all Korean comments and log messages to English

56c050e

- Update JavaDoc comments in controllers and services - Translate Korean log messages to English for consistency

chore: clean up log messages by removing emojis

81b6caf

- Remove emoji characters from all log statements across service classes

Yoo-SH requested review from Copilot, kAYI0019 and qowlgur121 August 21, 2025 16:53

Yoo-SH assigned Copilot Aug 21, 2025

Copilot AI reviewed Aug 21, 2025

View reviewed changes

Yoo-SH merged commit db1d5f8 into develop Aug 21, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Removes emoji characters from all log messages across service classes to improve log readability and maintain professional appearance in production environments. - #35

Removes emoji characters from all log messages across service classes to improve log readability and maintain professional appearance in production environments.#35
Yoo-SH merged 2 commits into
developfrom
feature/log

Yoo-SH commented Aug 21, 2025

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Aug 21, 2025

Uh oh!

Copilot AI Aug 21, 2025

Uh oh!

Copilot AI Aug 21, 2025

Uh oh!

Copilot AI Aug 21, 2025

Uh oh!

Copilot AI Aug 21, 2025

Uh oh!

Copilot AI Aug 21, 2025

Uh oh!

Copilot AI Aug 21, 2025

Uh oh!

Copilot AI Aug 21, 2025

Uh oh!

Copilot AI Aug 21, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

	log.debug(" [UPLOAD] Step 1/5: Validating file: {}", filename);
	log.debug("[UPLOAD] Step 1/5: Validating file: {}", filename);

	log.info(" [UPLOAD] File upload completed successfully: id={}, filename={}, duration={}ms",
	log.info("[UPLOAD] File upload completed successfully: id={}, filename={}, duration={}ms",

	log.info(" [MINIO] Created MinIO bucket: {}", minioConfig.getBucketName());
	log.info("[MINIO] Created MinIO bucket: {}", minioConfig.getBucketName());

	log.debug(" [QUERY] Retrieving document: id={}", documentId);
	log.debug("[QUERY] Retrieving document: id={}", documentId);

	log.debug(" [QUERY] Retrieving documents with pagination: page={}, size={}",
	log.debug("[QUERY] Retrieving documents with pagination: page={}, size={}",

	log.info(" [STATUS] Document status updated: id={}, status={}", documentId, status);
	log.info("[STATUS] Document status updated: id={}, status={}", documentId, status);

	log.info(" [DELETE] Document details: filename={}, status={}, size={} bytes",
	log.info("[DELETE] Document details: filename={}, status={}, size={} bytes",

	log.warn(" [DELETE] Cannot delete document in processing state: id={}, status={}",
	log.warn("[DELETE] Cannot delete document in processing state: id={}, status={}",

Uh oh!

Conversation

Yoo-SH commented Aug 21, 2025

Summary of Changes

Type of Change

Related Issues

Testing Instructions

Screenshots (if applicable)

Checklist

Additional Notes

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Copilot AI Aug 21, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Aug 21, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Aug 21, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Aug 21, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Aug 21, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Aug 21, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Aug 21, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Aug 21, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Aug 21, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants