Fix/core build error#8
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes critical build errors that were preventing the application from starting properly. The changes address two main issues: an OpenAPI version configuration problem and a JPA auditing handler duplication error in Spring configuration.
- Downgraded SpringDoc OpenAPI from version 2.7.0 to 2.6.0 to resolve build failures
- Removed
@EnableJpaAuditingannotation from the main application class to fix Spring configuration duplication
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| core/build.gradle | Downgraded SpringDoc OpenAPI version from 2.7.0 to 2.6.0 |
| core/src/main/java/com/opencontext/OpenContextApplication.java | Removed @EnableJpaAuditing annotation and its import |
| import org.springframework.boot.autoconfigure.SpringBootApplication; | ||
| import org.springframework.data.jpa.repository.config.EnableJpaAuditing; | ||
| import org.springframework.scheduling.annotation.EnableAsync; | ||
|
|
There was a problem hiding this comment.
[nitpick] The removal of @EnableJpaAuditing suggests it's configured elsewhere to avoid duplication. Consider adding a comment explaining where JPA auditing is configured instead, to help future developers understand the application's auditing setup.
Suggested change
| // Note: JPA auditing is enabled in AuditingConfig.java to avoid duplication of @EnableJpaAuditing. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of Changes
Fixed critical build errors preventing the application from starting properly:
Type of Change
Related Issues
Addresses build errors and database connection issues that were preventing application startup.
Testing Instructions
docker-compose up -d postgres elasticsearch minio./gradlew clean build./gradlew bootRunScreenshots (if applicable)
N/A - Backend configuration fixes
Checklist
Additional Notes