Pull Request: Move Type Definitions to devDependencies#96
Conversation
👷 Deploy request for appcut pending review.Visit the deploys page to approve it
|
WalkthroughThe dependency "@types/pg" in the Changes
Poem
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
apps/web/package.json (1)
58-70: Optional: keepdevDependenciesalphabetically ordered for quick scanning.Re-ordering isn’t functionally required, yet a consistent alpha sort makes large manifests easier to diff and maintain.
- "@types/pg": "^8.15.4", - "@types/bun": "latest", + "@types/bun": "latest", + "@types/pg": "^8.15.4",
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
apps/web/package.json(1 hunks)
🔇 Additional comments (1)
apps/web/package.json (1)
59-59: Type-only package correctly moved todevDependencies– good call.
@types/pgis used exclusively for compile-time type checking, so excluding it from the runtime bundle trims the production image with zero functional impact.
No further issues spotted for this change. 👍
Pull Request: Move Type Definitions to devDependencies
Description
This pull request refactors the
package.jsonto relocate development-only type definition packages (@types/react,@types/react-dom,@types/pg) fromdependenciestodevDependencies. These packages are only needed during development and type checking, not in production runtime.This change aligns the dependency tree with best practices and helps reduce unnecessary bloat in the production bundle.
Fixes: N/A
Type of change
How Has This Been Tested?
bun installand running the project in dev and production builds to ensure no runtime issues.Test Configuration:
N/A
Screenshots (if applicable)
N/A
Checklist:
Additional context
This is a minor maintenance improvement to keep the
package.jsoncleaner and prevent bundling dev-only packages into production.Summary by CodeRabbit