Skip to content

Pull Request: Move Type Definitions to devDependencies#96

Merged
izadoesdev merged 2 commits into
OpenCut-app:mainfrom
sinanptm:main
Jun 25, 2025
Merged

Pull Request: Move Type Definitions to devDependencies#96
izadoesdev merged 2 commits into
OpenCut-app:mainfrom
sinanptm:main

Conversation

@sinanptm
Copy link
Copy Markdown
Contributor

@sinanptm sinanptm commented Jun 25, 2025

Description

This pull request refactors the package.json to relocate development-only type definition packages (@types/react, @types/react-dom, @types/pg) from dependencies to devDependencies. These packages are only needed during development and type checking, not in production runtime.

This change aligns the dependency tree with best practices and helps reduce unnecessary bloat in the production bundle.

Fixes: N/A

Type of change

  • Code refactoring

How Has This Been Tested?

  • Manual verification by reinstalling dependencies with bun install and running the project in dev and production builds to ensure no runtime issues.
  • Confirmed that all type checking and linting passes post-move.

Test Configuration:
N/A

Screenshots (if applicable)

N/A

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Additional context

This is a minor maintenance improvement to keep the package.json cleaner and prevent bundling dev-only packages into production.

Summary by CodeRabbit

  • Chores
    • Updated package dependencies to improve development environment management. No impact on end-user functionality.

@netlify
Copy link
Copy Markdown

netlify Bot commented Jun 25, 2025

👷 Deploy request for appcut pending review.

Visit the deploys page to approve it

Name Link
🔨 Latest commit 903cdf5

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Jun 25, 2025

Walkthrough

The dependency "@types/pg" in the apps/web/package.json file was moved from the "dependencies" section to the "devDependencies" section, making it a development-only dependency rather than a runtime one.

Changes

File(s) Change Summary
apps/web/package.json Moved "@types/pg" from "dependencies" to "devDependencies".

Poem

A hop and a skip, a package moves on,
From runtime to dev, its old place is gone.
No more in the bundle, just there to assist,
Helping the coders, not runtime to persist.
The garden is tidy, dependencies trimmed,
The web app grows strong, its future unlimned! 🥕


🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (1)
apps/web/package.json (1)

58-70: Optional: keep devDependencies alphabetically ordered for quick scanning.

Re-ordering isn’t functionally required, yet a consistent alpha sort makes large manifests easier to diff and maintain.

-    "@types/pg": "^8.15.4",
-    "@types/bun": "latest",
+    "@types/bun": "latest",
+    "@types/pg": "^8.15.4",
📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between c18b173 and 903cdf5.

📒 Files selected for processing (1)
  • apps/web/package.json (1 hunks)
🔇 Additional comments (1)
apps/web/package.json (1)

59-59: Type-only package correctly moved to devDependencies – good call.

@types/pg is used exclusively for compile-time type checking, so excluding it from the runtime bundle trims the production image with zero functional impact.
No further issues spotted for this change. 👍

@izadoesdev izadoesdev merged commit 067b6e3 into OpenCut-app:main Jun 25, 2025
1 check passed
zstar1003 pushed a commit to zstar1003/FlashCut that referenced this pull request Jan 28, 2026
Pull Request: Move Type Definitions to devDependencies
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants