Reenable writing check point files when using the MAP module#3146
Merged
andrew-platt merged 1 commit intoOpenFAST:devfrom Jan 16, 2026
Merged
Reenable writing check point files when using the MAP module#3146andrew-platt merged 1 commit intoOpenFAST:devfrom
andrew-platt merged 1 commit intoOpenFAST:devfrom
Conversation
3 tasks
Contributor
There was a problem hiding this comment.
Pull request overview
This PR re-enables checkpoint file writing and mode shape visualization when using the MAP mooring module by removing previously added safeguards that were blocking serialization of C interop objects.
Changes:
- Removed code generator logic that prevented packing of C objects (
C_obj%object) - Removed runtime checks blocking checkpoint file creation when MAP module is active
- Removed runtime check preventing mode shape visualization with MAP module
- Updated ElastoDyn comment to clarify that Hubf2Iner refers to the teeter axis
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| modules/openfast-registry/src/registry_gen_fortran.cpp | Removed code generator check that prevented packing C objects |
| modules/openfast-library/src/FAST_Subs.f90 | Removed runtime blocks preventing mode shape visualization and checkpoint file writing when MAP module is used |
| modules/map/src/MAP_Types.f90 | Removed auto-generated pack function checks for C objects (generated from registry changes) |
| modules/extloads/src/ExtLoadsDX_Types.f90 | Removed auto-generated pack function checks for C objects (generated from registry changes) |
| modules/externalinflow/src/ExternalInflow_Types.f90 | Removed auto-generated pack function checks for C objects (generated from registry changes) |
| modules/elastodyn/src/ElastoDyn_Types.f90 | Clarified comment describing Hubf2Iner as referring to the teeter axis |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
andrew-platt
approved these changes
Jan 16, 2026
Collaborator
andrew-platt
left a comment
andrew-platt
left a comment
There was a problem hiding this comment.
Thanks for fixing the ED_Types.f90 file as well. Not sure why that hadn't been updated before.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is ready to merge
Feature or improvement description
This PR closes #2947 where checkpoint file writing was disabled when the MAP module was used. This was due to a misunderstanding about how the MAP_Restore function works in re-initializing the C memory within the module. Once all the previous checks were removed, the code worked as intended.
Related issue, if one exists
#2947
Impacted areas of the software
FAST_Subs.f90and several_Types.f90filesAdditional supporting information