Fix for FAST.Farm issue #3183#3243
Merged
andrew-platt merged 8 commits intoOpenFAST:rc-4.2.1from Mar 10, 2026
Merged
Conversation
…s in data structure
- Increased arrays by one timeslice. Wind timeslice index=0 is now at `T_low-DT_high` - retrieval of wind now accounts for picking up one extra slice - if low res timestep `n==0`, set `T=-DT_high` wind equal to `T=0` wind - for lowres steps `n>0`, transfer last wind slice at `T=T_low_previous-DT_high` to `T=T_low_now-DT_high` - NOTE: it might also be possible to copy the `T=T_low_previous+n_high_low*DT_high` over to `T=T_low` since they are technically the same
Collaborator
Author
|
NOTE: the changes in the |
Collaborator
Author
|
After extensive debugging, the regression results match exactly, so no updates required on those. Testing included comparing the following:
|
deslaughter
approved these changes
Mar 10, 2026
Collaborator
deslaughter
left a comment
deslaughter
left a comment
There was a problem hiding this comment.
Great work. The indexing sure looks tricky.
This was referenced Mar 10, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ready to merge.
Feature or improvement description
This PR adds a slice of wind at
T=T_low - DT_highto the wind passed into AeroDyn from FAST.Farm. The 4D wind box now spans fromT=T_low - DT_highthroughT=T_low + n_high_low * DT_high.details
AeroDyn has an extrap/interp for inputs during calculations. However, the wind passed from FAST.Farm is a 4D wind box from
T=T_lowthroughT=T_low + n_high_low * DT_high. So ifT=T_low, the wind that AeroDyn receives is missing the wind slice atT=T_low - DT_highneeded for the interpolation of wind. However this rarely triggered an issue due to a bug in the way the time index into the 4D wind box was calculated (this has not been fixed in this PR).Related issue, if one exists
#3183, in particular comment #3183 (comment)
Impacted areas of the software
FAST.Farm and AWAE module calculations, but results are minimally impacted.
Additional supporting information
Another approach would have been to keep a copy of the previous wind in AeroDyn for the extrap/interp. However, this was attempted with little success and this method was chosen instead.
Generative AI usage
None. AI couldn't handle this one.
Test results, if applicable
TSinflowcases, which may be in part due to previous rounding.