Skip to content

Membrane support#1561

Open
hannahbaumann wants to merge 176 commits intomainfrom
membrane_prototype
Open

Membrane support#1561
hannahbaumann wants to merge 176 commits intomainfrom
membrane_prototype

Conversation

@hannahbaumann
Copy link
Contributor

@hannahbaumann hannahbaumann commented Oct 9, 2025

[Note from @atravitz: we are making an experimental release from this branch, and so this branch should not be merged into main just yet]

This PR addresses the following issues:

Checklist

  • Added a news entry

Developers certificate of origin

@codecov
Copy link

codecov bot commented Oct 10, 2025

Codecov Report

❌ Patch coverage is 62.90984% with 181 lines in your changes missing coverage. Please review.
✅ Project coverage is 91.05%. Comparing base (031e13c) to head (a72e135).

Files with missing lines Patch % Lines
...ts/protocols/openmm_septop/test_septop_protocol.py 35.75% 115 Missing ⚠️
...s/protocols/openmm_rfe/test_hybrid_top_protocol.py 8.57% 32 Missing ⚠️
.../tests/protocols/openmm_abfe/test_abfe_protocol.py 68.65% 21 Missing ⚠️
src/openfe/protocols/openmm_md/plain_md_methods.py 81.81% 2 Missing ⚠️
...openfe/protocols/openmm_rfe/_rfe_utils/relative.py 66.66% 2 Missing ⚠️
...openfe/protocols/openmm_rfe/hybridtop_protocols.py 60.00% 2 Missing ⚠️
...nfe/protocols/openmm_septop/equil_septop_method.py 90.90% 2 Missing ⚠️
src/openfe/protocols/openmm_utils/omm_settings.py 84.61% 2 Missing ⚠️
src/openfe/protocols/openmm_afe/abfe_units.py 80.00% 1 Missing ⚠️
src/openfe/protocols/openmm_rfe/hybridtop_units.py 50.00% 1 Missing ⚠️
... and 1 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1561      +/-   ##
==========================================
- Coverage   94.79%   91.05%   -3.74%     
==========================================
  Files         205      205              
  Lines       17957    18342     +385     
==========================================
- Hits        17022    16702     -320     
- Misses        935     1640     +705     
Flag Coverage Δ
fast-tests 91.05% <62.90%> (?)
slow-tests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

hannahbaumann and others added 25 commits October 13, 2025 13:41
@hannahbaumann
Copy link
Contributor Author

pre-commit.ci autofix

return "vacuum"
elif "gufe.components.proteincomponent" in component_types:
if (
"gufe.components.proteincomponent" in component_types
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@IAlibay @atravitz this is not very pretty, but since we're not loading the actual components, we cannot check the base types directly. Not sure if there's a better way.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might make sense to spin this off into a separate PR?

@atravitz
Copy link
Contributor

atravitz commented Mar 9, 2026

pre-commit.ci autofix

@github-actions
Copy link

github-actions bot commented Mar 9, 2026

No API break detected ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Membrane: Add warning/validation for barostat usage

4 participants