Skip to content

update abfe test data#1862

Open
atravitz wants to merge 6 commits intomainfrom
maint/update_abfe_test_data
Open

update abfe test data#1862
atravitz wants to merge 6 commits intomainfrom
maint/update_abfe_test_data

Conversation

@atravitz
Copy link
Contributor

@atravitz atravitz commented Mar 5, 2026

resolves #1804

Checklist

  • All new code is appropriately documented (user-facing code must have complete docstrings).
  • Added a news entry, or the changes are not user-facing.
  • Ran pre-commit: you can run pre-commit locally or comment on this PR with pre-commit.ci autofix.

Manual Tests: these are slow so don't need to be run every commit, only before merging and when relevant changes are made (generally at reviewer-discretion).

Developers certificate of origin

@atravitz atravitz requested a review from IAlibay March 5, 2026 00:31
@atravitz atravitz marked this pull request as ready for review March 5, 2026 00:32
@codecov
Copy link

codecov bot commented Mar 5, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 91.84%. Comparing base (d69baa6) to head (be08a62).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1862      +/-   ##
==========================================
- Coverage   94.31%   91.84%   -2.47%     
==========================================
  Files         205      205              
  Lines       17957    17960       +3     
==========================================
- Hits        16936    16496     -440     
- Misses       1021     1464     +443     
Flag Coverage Δ
fast-tests 91.84% <100.00%> (?)
slow-tests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Member

@IAlibay IAlibay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure why single repeat changed to stdev, also do you want to keep testing the old code path with the previous data too?

solvent 1 5.5 1.4
standard_state_correction 1 0.0 0.0
standard_state_correction 1 -9.0 0.0
standard_state_correction 1 0.0 0.0
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

are these additional entries expected now that units are split? I'm wary that some assumption in gather_abfe.py is being violated.

@atravitz
Copy link
Contributor Author

atravitz commented Mar 6, 2026

Not sure why single repeat changed to stdev, also do you want to keep testing the old code path with the previous data too?

good point - we now test against both pre- PR #1776 changes and the current behavior.

@atravitz atravitz requested a review from IAlibay March 6, 2026 20:36
@github-actions
Copy link

No API break detected ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add new tests for abfe gather

2 participants