Conversation
src/openfecli/tests/commands/test_gather/test_abfe_single_repeat_dg_.tsv
Outdated
Show resolved
Hide resolved
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1862 +/- ##
==========================================
- Coverage 94.31% 91.84% -2.47%
==========================================
Files 205 205
Lines 17957 17960 +3
==========================================
- Hits 16936 16496 -440
- Misses 1021 1464 +443
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
IAlibay
left a comment
There was a problem hiding this comment.
Not sure why single repeat changed to stdev, also do you want to keep testing the old code path with the previous data too?
| solvent 1 5.5 1.4 | ||
| standard_state_correction 1 0.0 0.0 | ||
| standard_state_correction 1 -9.0 0.0 | ||
| standard_state_correction 1 0.0 0.0 |
There was a problem hiding this comment.
are these additional entries expected now that units are split? I'm wary that some assumption in gather_abfe.py is being violated.
good point - we now test against both pre- PR #1776 changes and the current behavior. |
|
No API break detected ✅ |
resolves #1804
Checklist
newsentry, or the changes are not user-facing.pre-commit.ci autofix.Manual Tests: these are slow so don't need to be run every commit, only before merging and when relevant changes are made (generally at reviewer-discretion).
Developers certificate of origin