feat(qa-changes): capture visual evidence for frontend PRs - #403
Conversation
Add a Phase 3 step: when a PR has frontend work, run the affected screens from the branch's final state and capture a screenshot of each relevant state (empty, loading, error, populated) plus a GIF of the key interaction end to end. Where behavior changes, include before/after. Attach it all to the PR so the change can be reviewed by observation, not by reading the diff. Adds a matching 'Visual Evidence' block to the report format and a key principle, and regenerates the skills catalog. Co-authored-by: smolpaws <engel@enyst.org>
4f0b766 to
5f35ee0
Compare
|
👋 This PR needs a couple of things fixed before OpenHands can review it:
Push an update once this is addressed and this check re-runs automatically. This is an automated check - no AI was used to generate this comment. |
3 similar comments
|
👋 This PR needs a couple of things fixed before OpenHands can review it:
Push an update once this is addressed and this check re-runs automatically. This is an automated check - no AI was used to generate this comment. |
|
👋 This PR needs a couple of things fixed before OpenHands can review it:
Push an update once this is addressed and this check re-runs automatically. This is an automated check - no AI was used to generate this comment. |
|
👋 This PR needs a couple of things fixed before OpenHands can review it:
Push an update once this is addressed and this check re-runs automatically. This is an automated check - no AI was used to generate this comment. |
3 participants
What
Add a step to the
qa-changesskill: capture visual evidence for frontend PRs.If the PR has frontend work, QA should run the affected screens from the branch's final state and record what a reviewer would otherwise have to imagine from the diff — so the change can be reviewed by observation, not by reading code.
The step
For frontend PRs, after exercising the UI:
.pr/and reference the raw URLs. Label each clearly.Kept proportional (only the screens the PR touches) with an explicit "say so if you can't render a screen" escape hatch — consistent with the skill's existing "give up gracefully / report honestly" ethos.
Changes
skills/qa-changes/SKILL.md: new "Capture visual evidence" step in Phase 3, a "Visual Evidence" collapsible in the report format, and a matching key principle.skills/index.js: regenerated skills catalog (node scripts/build-skills-catalog.mjs).Docs-only change to a skill; no code paths affected.