feat: add refactoring advisor skill - #424
Conversation
1db2c6a to
6c0a106
Compare
|
👋 This PR needs a couple of things fixed before OpenHands can review it:
Push an update once this is addressed and this check re-runs automatically. This is an automated check - no AI was used to generate this comment. |
2 similar comments
|
👋 This PR needs a couple of things fixed before OpenHands can review it:
Push an update once this is addressed and this check re-runs automatically. This is an automated check - no AI was used to generate this comment. |
|
👋 This PR needs a couple of things fixed before OpenHands can review it:
Push an update once this is addressed and this check re-runs automatically. This is an automated check - no AI was used to generate this comment. |
neubig
left a comment
There was a problem hiding this comment.
Thank you @wusuiling-if !
The HUMAN section is not sufficient here, given that this is adding a skill I'd expect a manual test to demonstrate that this actually works on a reasonably large-scale codebase. Could you demonstrate this with a before-after example of the codebase that you refactored?
Summary
Add the
refactoring-advisorskill requested in #85. The skill audits functions, classes, modules/packages, and cross-cutting dependencies, then produces evidence-backed refactoring proposals without modifying implementation code.The workflow:
large-codebasemarketplace and generated skills catalogCloses #85
Validation
npm run build:skillspython3 scripts/sync_extensions.py --checkpython3 -m pytest -q tests/test_refactoring_advisor.py tests/test_skills_catalog.py tests/test_sync_extensions.py tests/test_plugin_manifest.py tests/test_skill_plugin_loading.py tests/test_skills_have_readme.py -k 'not iterate_loads_as_sdk_plugin'(169 passed, 1 deselected)The full Python suite was not available locally because this machine has Python 3.10 and no
uv, while the project requires Python 3.12 and the test group includesopenhands-sdk,mcp, and other unavailable dependencies. The repository sync check also reports the pre-existing non-blocking marketplace warning forplugins/issue-duplicate-checker.HUMAN: No separate manual runtime test was performed. The contributor validated the change with
npm run build:skills, the repository synchronization check, and the focused Python test suite (169 passed, 1 deselected); the exact commands and environment limitations are documented above.