fix(skills): route "add a skill" to skill-creator - #453
Open
VascoSch92 wants to merge 1 commit into
Open
Conversation
Saying 'add a skill' matched add-skill (GitHub import) instead of skill-creator (authoring), because 'add' was absent from skill-creator's triggers and present in add-skill's. Add the 'add a skill' synonym to skill-creator and scope add-skill to URL-based imports so they no longer collide. Refs OpenHands/OpenHands#16320
Contributor
|
👋 This PR needs a couple of things fixed before OpenHands can review it:
Push an update once this is addressed and this check re-runs automatically. This is an automated check - no AI was used to generate this comment. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Per #454, saying "add a skill" did not trigger the intended skill. The request routed toward
add-skill(which imports an existing skill from a GitHub URL and installs it locally under.agents/skills/) instead ofskill-creator(which is the authoring skill).Root cause is a trigger-vocabulary collision:
skill-creator's description matchedcreate/writebut not the wordadd.add-skillis named add-skill and claimedadd a skillin its description.So the user's exact verb ("add") pulled the request to the wrong skill.
Fixes #454.
Change (minimal — two frontmatter descriptions only)
"add a skill"/"make a new skill"to its triggers, and a one-line note to prefer it (overadd-skill) when authoring from scratch.skill-creator, so the two no longer compete for "add a skill".No logic, script, or file-layout changes.
Note / out of scope
The issue also expected new skills to land globally (e.g.
.openhands/) rather than locally. That is an Agent Canvas placement concern, not a trigger-routing one, and is intentionally left out of this minimal fix.Refs #454