Added italian language#132
Conversation
WalkthroughA new Italian localization resource file is added, supplying translated UI strings and positional placeholders for app management, authentication, errors, device flow, settings, appearance, navigation, installation states, sorting/filtering, language labels, repository discovery, and logs. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Poem
Pre-merge checks✅ Passed checks (3 passed)
Comment |
|
@vincenzomarotta Thanks for the contribution and for adding Italian support! 🇮🇹 I noticed that the new Let me know if you have any questions—happy to help 👍 |
There was a problem hiding this comment.
Actionable comments posted: 5
📜 Review details
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
composeApp/src/commonMain/composeResources/values-it/strings-it.xml
🔇 Additional comments (2)
composeApp/src/commonMain/composeResources/values-it/strings-it.xml (2)
160-160: Verify gender/number agreement for "Installate"."Installate" is feminine plural, but for a status label it should typically be masculine singular "Installato" or neuter "Installata" depending on what it refers to (the app - "l'app" is feminine, but "il programma" would be masculine). Please verify the appropriate grammatical form based on usage context.
Suggested alternatives
If referring to the app (l'app - feminine):
- <string name="installed">Installate</string> + <string name="installed">Installata</string>If using a neutral/general form:
- <string name="installed">Installate</string> + <string name="installed">Installato</string>
189-189: Verify gender agreement for "Installate".Similar to line 160, "Installate" is feminine plural. For "Installed version" it should be "Installata" (feminine singular referring to "versione" which is feminine) or "Installato" depending on context.
🔎 Suggested fix
Since "versione" (version) is feminine in Italian:
- <string name="installed_version">• Installate: %1$s</string> + <string name="installed_version">• Installata: %1$s</string>
|
@rainxchzed my bad, didn't notice I messed up the commit. |
…t.xml Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
There was a problem hiding this comment.
Actionable comments posted: 4
🧹 Nitpick comments (4)
composeApp/src/commonMain/composeResources/values-it/strings-it.xml (4)
68-68: Use Italian form "repository" instead of "repositories".In Italian, "repository" serves as both singular and plural. Replace "repositories" with "repository" for proper Italian usage.
🔎 Proposed fixes
- <string name="discover_repositories">Scopri Repositories</string> + <string name="discover_repositories">Scopri Repository</string>- <string name="home_finding_repositories">Ricerca di repositories...</string> + <string name="home_finding_repositories">Ricerca di repository...</string>- <string name="home_no_more_repositories">Non ci sono più repositories</string> + <string name="home_no_more_repositories">Non ci sono più repository</string>- <string name="home_failed_to_load_repositories">Impossibile caricare repositories</string> + <string name="home_failed_to_load_repositories">Impossibile caricare repository</string>Also applies to: 221-221, 223-223, 225-225
155-155: Translate "logs" for consistency.The string mixes Italian and English. Consider translating "logs" to "Log di installazione" or "Registri di installazione".
🔎 Proposed fix
- <string name="install_logs">Installa logs</string> + <string name="install_logs">Log di installazione</string>
203-203: Use "Annullato" for consistency.For consistency with the cancel action translations elsewhere (lines 27, 144), use "Annullato" instead of "Cancellato".
🔎 Proposed fix
- <string name="log_cancelled">Cancellato</string> + <string name="log_cancelled">Annullato</string>
234-234: Improve word order."Superato limite di richieste" sounds awkward in Italian. A more natural phrasing would be "Limite di richieste superato".
🔎 Proposed fix
- <string name="rate_limit_exceeded">Superato limite di richieste</string> + <string name="rate_limit_exceeded">Limite di richieste superato</string>
|
Tip For best results, initiate chat on the files or code changes. 🧩 Analysis chain🏁 Script executed: Length of output: 15325 @rainxchzed, I found that @vincenzomarotta has already applied 2 of my suggestions (the "cancel" translations), but there are 7 remaining suggestions that still need to be applied: Pending Suggestions Summary
@vincenzomarotta, you can apply these suggestions directly from the GitHub UI by clicking the "Commit suggestion" button on each of the pending review comments, or you can manually update the file with the corrections listed above. Let me know if you need any clarification! 👍 |
There was a problem hiding this comment.
Actionable comments posted: 0
♻️ Duplicate comments (1)
composeApp/src/commonMain/composeResources/values-it/strings-it.xml (1)
27-27: Apply the previously suggested "cancel" translation.The past review comment for this line indicated it should use "Annulla" instead of "Cancella" and was marked as addressed, but the current code still shows "Cancella". In Italian UI contexts, "Annulla" is the standard translation for "cancel" actions, while "Cancella" implies "delete".
Note that line 144 (
cancel_download) correctly uses "Annulla download", so this line should be updated for consistency.🔎 Proposed fix
- <string name="cancel">Cancella</string> + <string name="cancel">Annulla</string>
🧹 Nitpick comments (1)
composeApp/src/commonMain/composeResources/values-it/strings-it.xml (1)
155-155: Consider using Italian term for consistency.The string uses "Installa logs" which mixes Italian with the English word "logs". For better localization consistency, consider using "Installa i log" or "Log di installazione".
🔎 Proposed alternatives
Option 1 (simpler):
- <string name="install_logs">Installa logs</string> + <string name="install_logs">Installa i log</string>Option 2 (more descriptive):
- <string name="install_logs">Installa logs</string> + <string name="install_logs">Log di installazione</string>
📜 Review details
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
composeApp/src/commonMain/composeResources/values-it/strings-it.xml
🔇 Additional comments (2)
composeApp/src/commonMain/composeResources/values-it/strings-it.xml (2)
15-15: Excellent work applying the previous review suggestions!Almost all of the grammatical and translation issues flagged in previous reviews have been successfully corrected:
- "Aggiornamento generale fallito" (line 15) ✓
- "Attualmente" (line 36) ✓
- Lowercase "completa" (line 54) ✓
- Plural "limiti API" (line 58) ✓
- "reindirizzamento" (line 127) ✓
- "Annulla download" (line 144) ✓
- "gratuite" for feminine plural agreement (line 236) ✓
- "Si resetta tra" (line 237) ✓
The Italian translations now follow proper grammar, gender/number agreement, and standard UI terminology.
Also applies to: 36-36, 54-54, 58-58, 127-127, 144-144, 236-236, 237-237
1-245: High-quality Italian localization with comprehensive coverage.This localization file provides thorough Italian translations across all app features including authentication, app management, discovery, settings, and error handling. The translations demonstrate:
- Proper gender and number agreement throughout
- Appropriate Italian UI terminology
- Correct placeholder formatting for dynamic content
- Proper XML formatting and entity escaping
The contributor has successfully addressed nearly all previous review feedback, resulting in a polished localization file.
|
Thank you soo much for your contribution @vincenzomarotta 💖 |
Added italian language as string file
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.