Add hindi localiation#248
Conversation
WalkthroughA new Hindi localization resource file is added: Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 4✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches🧪 Generate unit tests (beta)
No actionable comments were generated in the recent review. 🎉 Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 3
🤖 Fix all issues with AI agents
In `@core/presentation/src/commonMain/composeResources/value-hi/strings-hi.xml`:
- Around line 1-325: The resource directory is misnamed "value-hi" which breaks
Android localization resolution; move/rename the directory to "values-hi" and
place the existing strings-hi.xml inside it (the file containing <string
name="app_name">GitHub Store</string> and other keys such as "installed_apps"
and "error_generic") so resources resolve correctly; after moving, verify there
are no stale references to "value-hi" in project configs or build scripts and
run a quick resource/CI build to confirm resolution.
- Line 35: The Hindi string resource updating_x_of_y uses reversed placeholders
causing progress to show total before current; update the format in the string
resource named "updating_x_of_y" to use the correct placeholder order so the
first argument (current) is %1$d and the second argument (total) is %2$d (i.e.,
swap the placeholders so it reads "%1$d में से %2$d अपडेट हो रहा है") to match
the caller that passes (progress.current, progress.total).
- Line 305: The Hindi string resource showing_x_of_y_repositories has its
placeholders reversed ("%2$d ... %1$d") causing total and current repository
counts to be shown in the wrong order; update the format string for resource
name showing_x_of_y_repositories to use "%1$d ... %2$d" so repoCount (first
argument) appears before totalCount (second argument).
🧹 Nitpick comments (1)
core/presentation/src/commonMain/composeResources/value-hi/strings-hi.xml (1)
272-272: Improve Hindi translation for "last synced".The word "सिंका" is not standard Hindi. Consider using "अंतिम सिंक" (last sync) or "अंतिम सिंक किया गया" (last synced) for better readability.
📝 Suggested improvement
- <string name="last_synced">अंतिम सिंका</string> + <string name="last_synced">अंतिम सिंक</string>
There was a problem hiding this comment.
Actionable comments posted: 3
🤖 Fix all issues with AI agents
In `@core/presentation/src/commonMain/composeResources/values-hi/strings-hi.xml`:
- Line 272: Replace the misspelled Hindi string for the resource named
"last_synced": change the value "अंतिम सिंका" to the correct transliteration
"अंतिम सिंक" so the string resource <string name="last_synced"> uses "अंतिम
सिंक" instead of "अंतिम सिंका".
- Around line 1-325: The Hindi strings file is missing 11 keys from the English
base and contains 2 extraneous keys; add the missing string resources
bottom_nav_apps_title, bottom_nav_home_title, bottom_nav_profile_title,
bottom_nav_search_title, home_category_hot_release, home_category_most_popular,
released_days_ago, released_hours_ago, released_just_now, released_on_date,
released_yesterday with appropriate Hindi translations, and delete the
extraneous keys home_category_new and home_category_recently_updated; update the
resource block so each added key uses the same naming/placeholder patterns as
existing entries (e.g., %1$s/%1$d) to match usages like updated_hours_ago and
updated_on_date.
- Line 35: The Hindi translations for the placeholders are reversed: update the
string resources updating_x_of_y and showing_x_of_y_repositories so the
placeholders are swapped to match the English semantics (current then total).
Replace "%1$d में से %2$d" with "%2$d में से %1$d" in the string named
"updating_x_of_y" and likewise replace "%1$d में से %2$d" with "%2$d में से
%1$d" in "showing_x_of_y_repositories" so %1$d represents the current value and
%2$d the total.
🧹 Nitpick comments (2)
core/presentation/src/commonMain/composeResources/values-hi/strings-hi.xml (2)
32-32: Inconsistent error terminology: "गलती" vs "त्रुटि".The file uses "गलती" (colloquial, meaning "mistake") for
error_with_message,auth_error_with_message,log_error,log_error_with_message, anderror_generic, while "त्रुटि" (formal, meaning "error") is used on lines 64 and 148. For a technical UI, "त्रुटि" is more appropriate and should be used consistently throughout.Also applies to: 46-46, 205-206, 213-213
274-276: Placeholder format inconsistency:%dvs%1$d.
minutes_ago,hours_ago, anddays_ago(lines 274–276) use bare%d, while their counterparts elsewhere in the file (e.g.,updated_hours_agoat line 229,time_minutes_agoat line 320) use positional%1$d. Positional placeholders are preferred in localization resources for translator clarity and to avoid argument-ordering bugs.- <string name="minutes_ago">%d मिनट पहले</string> - <string name="hours_ago">%d घंटे पहले</string> - <string name="days_ago">%d दिन पहले</string> + <string name="minutes_ago">%1$d मिनट पहले</string> + <string name="hours_ago">%1$d घंटे पहले</string> + <string name="days_ago">%1$d दिन पहले</string>
|
now this PR can be merged |
|
Yeah thanks for your patience and contribution @adnan-bhaldar ! |
2 participants
Create strings-hi.xml
Summary by CodeRabbit