chore(android): update app icon assets and adaptive icon configuration#272
Conversation
This commit updates the Android app launcher icons, including changes to the adaptive icon configuration and background color. - **chore(android)**: Updated adaptive icon XML files to use `ic_launcher_foreground` for the monochrome layer. - **chore(android)**: Updated `ic_launcher_background` color to a lighter shade (`#1C1B1B`). - **chore(android)**: Updated launcher icon, foreground, and round icon `.webp` assets across all density buckets (hdpi to xxxhdpi). - **chore(android)**: Updated Play Store icon and main logo image assets.
|
Caution Review failedThe pull request is closed. ℹ️ Recent review infoConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro ⛔ Files ignored due to path filters (2)
📒 Files selected for processing (3)
WalkthroughAdaptive launcher icon XMLs updated to reference the mipmap foreground monochrome asset, launcher background color adjusted, splash drawable inset reduced, and a composable profile icon given a dark circular background with inner padding. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This commit updates the Android app launcher icons, including changes to the adaptive icon configuration and background color. - **chore(android)**: Updated adaptive icon XML files to use `ic_launcher_foreground` for the monochrome layer. - **chore(android)**: Updated `ic_launcher_background` color to a lighter shade (`#1C1B1B`). - **chore(android)**: Updated launcher icon, foreground, and round icon `.webp` assets across all density buckets (hdpi to xxxhdpi). - **chore(android)**: Updated Play Store icon and main logo image assets.
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@composeApp/src/androidMain/res/mipmap-anydpi-v26/ic_launcher.xml`:
- Line 5: Replace the monochrome drawable reference that currently points to the
full foreground mipmap with the dedicated single-color vector asset: change the
monochrome android:drawable from `@mipmap/ic_launcher_foreground` to
`@drawable/ic_launcher_monochrome` in ic_launcher.xml (and make the identical
change in ic_launcher_round.xml) so the adaptive themed icon uses the proper
monochrome asset.
ℹ️ Review info
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (2)
composeApp/src/androidMain/ic_launcher-playstore.pngis excluded by!**/*.pngcomposeApp/src/androidMain/res/drawable/ic_logo.pngis excluded by!**/*.png
📒 Files selected for processing (18)
composeApp/src/androidMain/res/mipmap-anydpi-v26/ic_launcher.xmlcomposeApp/src/androidMain/res/mipmap-anydpi-v26/ic_launcher_round.xmlcomposeApp/src/androidMain/res/mipmap-hdpi/ic_launcher.webpcomposeApp/src/androidMain/res/mipmap-hdpi/ic_launcher_foreground.webpcomposeApp/src/androidMain/res/mipmap-hdpi/ic_launcher_round.webpcomposeApp/src/androidMain/res/mipmap-mdpi/ic_launcher.webpcomposeApp/src/androidMain/res/mipmap-mdpi/ic_launcher_foreground.webpcomposeApp/src/androidMain/res/mipmap-mdpi/ic_launcher_round.webpcomposeApp/src/androidMain/res/mipmap-xhdpi/ic_launcher.webpcomposeApp/src/androidMain/res/mipmap-xhdpi/ic_launcher_foreground.webpcomposeApp/src/androidMain/res/mipmap-xhdpi/ic_launcher_round.webpcomposeApp/src/androidMain/res/mipmap-xxhdpi/ic_launcher.webpcomposeApp/src/androidMain/res/mipmap-xxhdpi/ic_launcher_foreground.webpcomposeApp/src/androidMain/res/mipmap-xxhdpi/ic_launcher_round.webpcomposeApp/src/androidMain/res/mipmap-xxxhdpi/ic_launcher.webpcomposeApp/src/androidMain/res/mipmap-xxxhdpi/ic_launcher_foreground.webpcomposeApp/src/androidMain/res/mipmap-xxxhdpi/ic_launcher_round.webpcomposeApp/src/androidMain/res/values/colors.xml
| <background android:drawable="@color/ic_launcher_background"/> | ||
| <foreground android:drawable="@mipmap/ic_launcher_foreground"/> | ||
| <monochrome android:drawable="@drawable/ic_launcher_monochrome"/> | ||
| <monochrome android:drawable="@mipmap/ic_launcher_foreground"/> |
There was a problem hiding this comment.
🧩 Analysis chain
🌐 Web query:
Android 13 adaptive icons monochrome layer requirements specifications
💡 Result:
Android 13 “themed app icons” (API 33) requires that your launcher icon be an adaptive icon that includes an optional monochrome layer; the system tints that monochrome layer using the user’s wallpaper/theme colors when the user enables Themed icons and the launcher supports it. [2]
Monochrome layer requirements (spec)
From the Android adaptive icon design spec, to support theming you should provide a single monochrome layer and follow the same adaptive-icon sizing rules: [1]
- Provide exactly one monochrome drawable layer referenced from
<monochrome>inside<adaptive-icon>. [1] - Size the monochrome layer (and other layers) to 108 × 108 dp. [1][3]
- Keep artwork within the “safe” region: the system may clip with different masks; guidance calls for a logo at least 48 × 48 dp and not exceeding 66 × 66 dp (so it won’t be clipped). [1]
- Leave the outer 18 dp on each side for masking and visual effects (parallax/pulsing). [1][3]
- Use clean edges; don’t bake in masks or background shadows around the icon outline. [1]
- The
<monochrome>drawable can be a vector or bitmap (vectors preferred). [1]
Resource / XML wiring
Define the adaptive icon XML (commonly under res/mipmap-anydpi-v26/) with a <monochrome> entry: [1]
<adaptive-icon xmlns:android="http://schemas.android.com/apk/res/android">
<background android:drawable="@drawable/ic_launcher_background" />
<foreground android:drawable="@drawable/ic_launcher_foreground" />
<monochrome android:drawable="@drawable/ic_launcher_monochrome" />
</adaptive-icon>🏁 Script executed:
# Find drawable and mipmap resources related to launcher icons
find composeApp/src/androidMain/res -type f -name "*ic_launcher*" | head -20Repository: rainxchzed/Github-Store
Length of output: 1272
🏁 Script executed:
cat -n composeApp/src/androidMain/res/mipmap-anydpi-v26/ic_launcher.xmlRepository: rainxchzed/Github-Store
Length of output: 442
🏁 Script executed:
cat -n composeApp/src/androidMain/res/drawable/ic_launcher_monochrome.xmlRepository: rainxchzed/Github-Store
Length of output: 27780
🏁 Script executed:
cat -n composeApp/src/androidMain/res/mipmap-anydpi-v26/ic_launcher_round.xmlRepository: rainxchzed/Github-Store
Length of output: 442
Use a dedicated monochrome asset for themed icons.
Line 5 currently reuses the full foreground mipmap; this violates the Android adaptive icon specification for themed icons (API 33+) which requires a single-color monochrome drawable. The project already has @drawable/ic_launcher_monochrome available as a properly formatted vector asset.
Also apply this fix to ic_launcher_round.xml which has the same issue.
Suggested change
- <monochrome android:drawable="@mipmap/ic_launcher_foreground"/>
+ <monochrome android:drawable="@drawable/ic_launcher_monochrome"/>📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| <monochrome android:drawable="@mipmap/ic_launcher_foreground"/> | |
| <monochrome android:drawable="@drawable/ic_launcher_monochrome"/> |
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In `@composeApp/src/androidMain/res/mipmap-anydpi-v26/ic_launcher.xml` at line 5,
Replace the monochrome drawable reference that currently points to the full
foreground mipmap with the dedicated single-color vector asset: change the
monochrome android:drawable from `@mipmap/ic_launcher_foreground` to
`@drawable/ic_launcher_monochrome` in ic_launcher.xml (and make the identical
change in ic_launcher_round.xml) so the adaptive themed icon uses the proper
monochrome asset.
- Add background color and padding to the profile image in `HomeRoot.kt` - Update `ic_launcher_background` color to `#121212` - Reduce splash screen icon inset from 48dp to 32dp - Update `app_icon.png` resource
1 participant
This commit updates the Android app launcher icons, including changes to the adaptive icon configuration and background color.
ic_launcher_foregroundfor the monochrome layer.ic_launcher_backgroundcolor to a lighter shade (#1C1B1B)..webpassets across all density buckets (hdpi to xxxhdpi).Summary by CodeRabbit