Skip to content

UI fix #310

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rainxchzed merged 2 commits into from
Mar 8, 2026
Merged

UI fix #310

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d036496
Refactor HomeFilterChips and update selected category text color
rainxchzed Mar 8, 2026
466c895
Refactor HomeFilterChips and update selected category text color
rainxchzed Mar 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions composeApp/src/commonMain/kotlin/zed/rainxch/githubstore/app/navigation/BottomNavigation.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -385,9 +385,9 @@ private fun LiquidGlassTabItem(
lineHeight = 12.sp
),
color = if (isSelected) {
MaterialTheme.colorScheme.onPrimaryContainer
} else {
MaterialTheme.colorScheme.onSurface
} else {
MaterialTheme.colorScheme.onSurface.copy(alpha = .7f)
},
maxLines = 1
)
Expand Down
4 changes: 1 addition & 3 deletions ...ntation/src/commonMain/kotlin/zed/rainxch/home/presentation/components/HomeFilterChips.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -252,7 +252,6 @@ fun LiquidGlassCategoryChips(
category = category,
isSelected = category == selectedCategory,
onSelect = { onCategorySelected(category) },
isDarkTheme = isDarkTheme,
modifier = Modifier.weight(1f),
onPositioned = { x, width ->
itemPositions[index] = x to width
Expand All @@ -276,7 +275,6 @@ private fun LiquidGlassCategoryChip(
category: HomeCategory,
isSelected: Boolean,
onSelect: () -> Unit,
isDarkTheme: Boolean,
modifier: Modifier = Modifier,
onPositioned: suspend (x: Float, width: Float) -> Unit
) {
Expand All @@ -301,7 +299,7 @@ private fun LiquidGlassCategoryChip(

val textColor by animateColorAsState(
targetValue = if (isSelected) {
MaterialTheme.colorScheme.onPrimaryContainer
MaterialTheme.colorScheme.onSurface
} else {
MaterialTheme.colorScheme.onSurface.copy(alpha = .65f)
},
Expand Down