Skip to content

Appimage support #41

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rainxchzed merged 6 commits into from
Dec 17, 2025
Merged

Appimage support #41

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
d212206
refactor(desktop): Improve AppImage and RPM installation
rainxchzed Dec 16, 2025
0026951
feat: Migrate from androidx.navigation3 to org.jetbrains.androidx.nav…
rainxchzed Dec 16, 2025
af25522
feat: Improve auth polling resilience and error handling
rainxchzed Dec 16, 2025
c367275
feat: Handle DEB installation on RPM-based Linux systems
rainxchzed Dec 17, 2025
01a1120
refactor(linux): Improve installer logic and asset scoring
rainxchzed Dec 17, 2025
c656ffa
refactor(installer): Improve Linux package installation and asset sel…
rainxchzed Dec 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions composeApp/build.gradle.kts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,8 +116,6 @@ kotlin {

implementation(libs.liquid)

implementation(libs.androidx.navigation3.runtime)
implementation(libs.androidx.navigation3.ui)
implementation(libs.jetbrains.navigation3.ui)
implementation(libs.jetbrains.lifecycle.viewmodel.compose)
implementation(libs.jetbrains.lifecycle.viewmodel)
Expand Down
Binary file modified composeApp/release/baselineProfiles/0/composeApp-release.dm
View file
Open in desktop
Binary file not shown.
Binary file modified composeApp/release/baselineProfiles/1/composeApp-release.dm
View file
Open in desktop
Binary file not shown.
49 changes: 38 additions & 11 deletions ...monMain/kotlin/zed/rainxch/githubstore/feature/auth/data/repository/AuthRepositoryImpl.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,11 +53,18 @@ class AuthRepositoryImpl(
val clientId = getGithubClientId()
val timeoutMs = start.expiresInSec * 1000L
var remainingMs = timeoutMs

val initialJitter = (0..2000).random().toLong()
delay(initialJitter)
remainingMs -= initialJitter

var intervalMs = (start.intervalSec.coerceAtLeast(5)) * 1000L
var consecutiveErrors = 0
var slowDownCount = 0
val maxConsecutiveErrors = 5
val maxSlowDownBeforeGiveUp = 8

Logger.d { "⏱️ Starting token polling. Expires in: ${start.expiresInSec}s, Interval: ${start.intervalSec}s" }
Logger.d { "⏱️ Starting token polling. Expires in: ${start.expiresInSec}s, Interval: ${start.intervalSec}s (jitter: ${initialJitter}ms)" }

while (remainingMs > 0) {
try {
Expand All @@ -75,21 +82,42 @@ class AuthRepositoryImpl(
val error = res.exceptionOrNull()
val msg = (error?.message ?: "").lowercase()

Logger.d { "📡 Poll response: $msg (errors: $consecutiveErrors/$maxConsecutiveErrors)" }
Logger.d { "📡 Poll response: $msg (slowdowns: $slowDownCount/$maxSlowDownBeforeGiveUp)" }

when {
"authorization_pending" in msg -> {
consecutiveErrors = 0
delay(intervalMs)
remainingMs -= intervalMs
slowDownCount = 0

val jitter = (0..500).random().toLong()
val waitTime = intervalMs + jitter

delay(waitTime)
remainingMs -= waitTime
}

"slow_down" in msg -> {
consecutiveErrors = 0
slowDownCount++

intervalMs += 5000
Logger.d { "⚠️ Slowing down polling to ${intervalMs}ms" }
delay(intervalMs)
remainingMs -= intervalMs

Logger.d { "⚠️ Rate limited. Slowing to ${intervalMs}ms (slowdown #$slowDownCount)" }

if (slowDownCount >= maxSlowDownBeforeGiveUp) {
throw Exception(
"GitHub authentication is experiencing high traffic. " +
"Please wait 1-2 minutes and try again."
)
}

val extraJitter = (0..3000).random().toLong()
val waitTime = intervalMs + extraJitter

Logger.d { "⏳ Waiting ${waitTime}ms (base: ${intervalMs}ms + jitter: ${extraJitter}ms)" }

delay(waitTime)
remainingMs -= waitTime
}

"access_denied" in msg -> {
Expand All @@ -110,21 +138,21 @@ class AuthRepositoryImpl(
consecutiveErrors++
Logger.d { "⚠️ Network error, retrying... ($consecutiveErrors/$maxConsecutiveErrors)" }

val backoffDelay = intervalMs * (1 + consecutiveErrors)

if (consecutiveErrors >= maxConsecutiveErrors) {
throw Exception(
"Network connection unstable during authentication. " +
"Please check your connection and try again."
)
}

val backoffDelay = intervalMs * (1 + consecutiveErrors)
delay(backoffDelay)
remainingMs -= backoffDelay
}

else -> {
consecutiveErrors++
Logger.d { "⚠️ Error: $msg (attempt $consecutiveErrors/$maxConsecutiveErrors)" }
Logger.d { "⚠️ Unknown error: $msg (attempt $consecutiveErrors/$maxConsecutiveErrors)" }

if (consecutiveErrors >= maxConsecutiveErrors) {
throw Exception("Authentication failed: $msg")
Expand All @@ -140,7 +168,6 @@ class AuthRepositoryImpl(
throw e
} catch (e: Exception) {
Logger.d { "❌ Poll error: ${e.message}" }
Logger.d { "❌ Error type: ${e::class.simpleName}" }
consecutiveErrors++

if (consecutiveErrors >= maxConsecutiveErrors) {
Expand Down
Loading