Skip to content

fix(tweaks): unbreak main — suspend getString in coroutine scope #577

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rainxchzed merged 1 commit into from
May 12, 2026
Merged

fix(tweaks): unbreak main — suspend getString in coroutine scope #577

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 15 additions & 12 deletions ...aks/presentation/src/commonMain/kotlin/zed/rainxch/tweaks/presentation/TweaksViewModel.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,7 @@ import zed.rainxch.tweaks.presentation.model.ProxyScopeFormState
import zed.rainxch.githubstore.core.presentation.res.Res
import zed.rainxch.githubstore.core.presentation.res.failed_to_save_proxy_settings
import zed.rainxch.githubstore.core.presentation.res.invalid_proxy_port
import zed.rainxch.githubstore.core.presentation.res.proxy_host_invalid
import zed.rainxch.githubstore.core.presentation.res.proxy_host_required
import zed.rainxch.githubstore.core.presentation.res.proxy_test_error_auth_required
import zed.rainxch.githubstore.core.presentation.res.proxy_test_error_dns
Expand Down Expand Up @@ -635,13 +636,14 @@ class TweaksViewModel(
val host =
form.host.trim().takeIf { isValidProxyHost(it) }
?: run {
val msg =
if (form.host.isBlank()) {
getString(Res.string.proxy_host_required)
} else {
getString(Res.string.proxy_host_invalid)
}
val isBlank = form.host.isBlank()
viewModelScope.launch {
val msg =
if (isBlank) {
getString(Res.string.proxy_host_required)
} else {
getString(Res.string.proxy_host_invalid)
}
_events.send(TweaksEvent.OnProxySaveError(msg))
}
return
Expand Down Expand Up @@ -1021,13 +1023,14 @@ class TweaksViewModel(
val host =
form.host.trim().takeIf { isValidProxyHost(it) }
?: run {
val msg =
if (form.host.isBlank()) {
getString(Res.string.proxy_host_required)
} else {
getString(Res.string.proxy_host_invalid)
}
val isBlank = form.host.isBlank()
viewModelScope.launch {
val msg =
if (isBlank) {
getString(Res.string.proxy_host_required)
} else {
getString(Res.string.proxy_host_invalid)
}
_events.send(TweaksEvent.OnProxyTestError(msg))
}
return null
Expand Down