docs: refresh CLAUDE.md files for 1.8.2 state#593
Merged
Conversation
Contributor
WalkthroughUpdates app metadata to 1.8.2 and adds base-name stem extraction to avoid auto-updating sibling assets; integrates stem-based filtering into InstalledAppsRepository auto-pick. Broad documentation updates add a Tweaks feature, reshuffle profile/settings responsibilities, and expand per-feature CLAUDE docs and release notes. ChangesDocumentation and Sibling App Detection Enhancement
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Tip 💬 Introducing Slack Agent: The best way for teams to turn conversations into code.Slack Agent is built on CodeRabbit's deep understanding of your code, so your team can collaborate across the entire SDLC without losing context.
Built for teams:
One agent for your entire SDLC. Right inside Slack. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Greptile SummaryThis PR brings all
Confidence Score: 5/5Safe to merge — the only code changes are an additive bug fix with a well-guarded fallback, and a what's-new entry; the rest is documentation. The bug fix is narrow and conservative: when no stem match is found the code falls back to the existing pool, so a false negative in stem extraction cannot strand an update. The new extractBaseStem logic mirrors the already-tested extractTokens n-gram pass. Documentation changes carry no runtime risk. No files require special attention. Important Files Changed
Flowchart%%{init: {'theme': 'neutral'}}%%
flowchart TD
A["resolveRelease(installedAssetName)"] --> B["extractBaseStem(installedAssetName)"]
B --> C{stem empty?}
C -- yes --> E["use full filterByPackageFlavor pool"]
C -- no --> D["filter pool: extractBaseStem(asset.name) == installedStem"]
D --> F{any matches?}
F -- yes --> G["use matching subset"]
F -- no --> E
E --> H["choosePrimaryAsset(autoPickPool)"]
G --> H
H --> I["fingerprintMatch ?? positionMatch ?? primary"]
Reviews (4): Last reviewed commit: "chore: add Approach section to CLAUDE.md..." | Re-trigger Greptile |
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
Comment on lines
+318
to
+324
| /** | ||
| * `1`, `10`, `1.0.0`, `v2.0.1`, `2024.04.10`, `1.0-rc1`, `beta3` — | ||
| * common patterns used in release filenames to encode the version. | ||
| * Conservative on purpose: false positives here just lose a stem | ||
| * character; false negatives would let a numeric variant leak into | ||
| * the stem and break the sibling-app detection. | ||
| */ |
There was a problem hiding this comment.
1.0-rc1 and beta3, implying the function recognises those patterns. After tokenisation, rc1 and beta3 are single tokens that don't satisfy either branch (all { it.isDigit() } or startsWith("v") && rest.all { it.isDigit() }), so they survive into the stem. A filename like AppA-1.0-rc1.apk produces stem "apparc1" while AppA-2.0.apk produces "appa" — no match, triggering the fallback pool (correct behaviour, but the doc implies it was handled). Removing 1.0-rc1 and beta3 from the examples aligns the doc with the conservative implementation.
Suggested change
| /** | |
| * `1`, `10`, `1.0.0`, `v2.0.1`, `2024.04.10`, `1.0-rc1`, `beta3` — | |
| * common patterns used in release filenames to encode the version. | |
| * Conservative on purpose: false positives here just lose a stem | |
| * character; false negatives would let a numeric variant leak into | |
| * the stem and break the sibling-app detection. | |
| */ | |
| /** | |
| * `1`, `10`, `1.0.0`, `v2.0.1`, `2024.04.10` — | |
| * common patterns used in release filenames to encode the version. | |
| * Conservative on purpose: false positives here just lose a stem | |
| * character; false negatives (e.g. `rc1`, `beta3` tokens after | |
| * tokenisation) would let a non-numeric variant leak into the stem — | |
| * the caller's pool fallback handles those cases gracefully. | |
| */ |
Comment on lines
+260
to
+278
| /** | ||
| * Extracts the **base-name stem** of an asset — the lowercased, | ||
| * separator-stripped concatenation of every token that isn't a | ||
| * version-like number, an arch token, or a flavor token. Used to | ||
| * detect "sibling app in the same repo" cases where two releases | ||
| * ship `AppA-1.10.apk` and `AppB-2.20.apk` and the auto-picker | ||
| * would otherwise swap one for the other based on numeric version | ||
| * alone (issue #591). | ||
| * | ||
| * `AppA-1.10.apk` → `"appa"` | ||
| * `AppB-2.20.apk` → `"appb"` | ||
| * `app-arm64-v8a-1.10.apk` and `app-x86_64-1.10.apk` → both `"app"` | ||
| * `app-1.0.apk` and `app-fdroid-1.0.apk` → both `"app"` | ||
| * | ||
| * Returns an empty string when stripping leaves nothing behind | ||
| * (release ships only a versioned filename like `2.0.apk`). Callers | ||
| * treat empty as "no stem signal — don't filter". | ||
| */ | ||
| fun extractBaseStem(assetName: String): String { |
There was a problem hiding this comment.
deriveGlob
extractBaseStem (and isVersionLikeToken) were inserted immediately after the closing */ of deriveGlob's KDoc block, placing them between the doc comment and the fun deriveGlob(...) declaration at line 332. As a result deriveGlob now has no KDoc attached (the floating comment above extractBaseStem's own block is not attributed to it), and IDEs will show deriveGlob as undocumented. Moving extractBaseStem + isVersionLikeToken to before the deriveGlob KDoc block restores the association.
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 4
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
feature/profile/CLAUDE.md (1)
85-90:⚠️ Potential issue | 🟡 Minor | ⚡ Quick winResolve scope contradiction inside this file.
These lines say settings moved to
feature/tweaks/, but the Module Structure andProfileStatesections still describe profile-owned settings artifacts. Please align those sections so ownership is unambiguous.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@feature/profile/CLAUDE.md` around lines 85 - 90, The document currently contradicts itself by saying "Settings moved out" to feature/tweaks while the Module Structure and ProfileState sections still list profile-owned settings; update those sections so they no longer claim ownership of appearance/installer/proxy/telemetry/cache/hidden lists/mirror/feedback settings: either remove those settings from the Module Structure and ProfileState descriptions or explicitly note they are delegated to feature/tweaks (and reference the feature name) and keep only ProfileRepository, Platform, ProfileViewModel, and cached getUser() details (e.g., CacheManager `profile:me`) as profile-owned; ensure the wording is consistent across Module Structure, ProfileState and any bullets mentioning Settings moved out.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@CLAUDE.md`:
- Line 165: The CLAUDE.md entry exposes a concrete secret value for
SIGNPATH_ORGANIZATION_ID; remove/redact that literal and document only the
variable name and where it is configured. Edit the Windows installer signing
paragraph (references: .github/workflows/build-desktop-platforms.yml, job name
sign-windows, variables SIGNPATH_API_TOKEN, SIGNPATH_ORGANIZATION_ID,
SIGNPATH_SIGNING_POLICY_SLUG) to replace the hard-coded GUID with a placeholder
or omit the value, e.g. keep "SIGNPATH_ORGANIZATION_ID (secret)" and mention it
is set in the CI secret store, and ensure no concrete secret values remain in
the text.
In
`@core/domain/src/commonMain/kotlin/zed/rainxch/core/domain/util/AssetVariant.kt`:
- Around line 325-330: The current isVersionLikeToken(token: String) only
recognizes pure digits and v+digits, so qualifier counters like "rc1" or "beta3"
are treated as stem content; update isVersionLikeToken to also recognize and
return true for tokens that combine alphabetical qualifiers with numeric
counters (e.g. "rc1", "beta3", "alpha2" and optionally with a leading 'v', e.g.
"vrc1") by adding a regex/conditional branch that matches patterns like optional
leading 'v' plus letters+digits (and optionally digits+letters if you want to be
liberal), keeping the existing digit and v+digit checks and using the function
name isVersionLikeToken to locate and replace the logic.
In `@feature/recently-viewed/CLAUDE.md`:
- Line 9: The fenced code block in CLAUDE.md is missing a language identifier;
locate the code fence that starts with ``` immediately before the directory tree
(the block containing "feature/recently-viewed/" and the list of files) and
change the opening fence to include a language identifier (e.g., ```text) so it
reads ```text while keeping the closing ``` unchanged, which will satisfy the
MD040 lint rule.
In `@feature/tweaks/CLAUDE.md`:
- Around line 9-28: Update the fenced code block in CLAUDE.md that shows the
feature/tweaks/ presentation tree to include a language tag (e.g., change the
opening ``` to ```text) so markdownlint MD040 is satisfied; locate the
triple-backtick block containing the directory tree and add the language marker
while keeping the block contents unchanged.
---
Outside diff comments:
In `@feature/profile/CLAUDE.md`:
- Around line 85-90: The document currently contradicts itself by saying
"Settings moved out" to feature/tweaks while the Module Structure and
ProfileState sections still list profile-owned settings; update those sections
so they no longer claim ownership of
appearance/installer/proxy/telemetry/cache/hidden lists/mirror/feedback
settings: either remove those settings from the Module Structure and
ProfileState descriptions or explicitly note they are delegated to
feature/tweaks (and reference the feature name) and keep only ProfileRepository,
Platform, ProfileViewModel, and cached getUser() details (e.g., CacheManager
`profile:me`) as profile-owned; ensure the wording is consistent across Module
Structure, ProfileState and any bullets mentioning Settings moved out.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: aa50be6e-c6dc-47a3-a1e0-0fd871760074
📒 Files selected for processing (14)
CLAUDE.mdcore/data/src/commonMain/kotlin/zed/rainxch/core/data/repository/InstalledAppsRepositoryImpl.ktcore/domain/src/commonMain/kotlin/zed/rainxch/core/domain/util/AssetVariant.ktcore/presentation/src/commonMain/composeResources/files/whatsnew/17.jsonfeature/apps/CLAUDE.mdfeature/auth/CLAUDE.mdfeature/details/CLAUDE.mdfeature/favourites/CLAUDE.mdfeature/home/CLAUDE.mdfeature/profile/CLAUDE.mdfeature/recently-viewed/CLAUDE.mdfeature/search/CLAUDE.mdfeature/starred/CLAUDE.mdfeature/tweaks/CLAUDE.md
Comment on lines
+325
to
+330
| private fun isVersionLikeToken(token: String): Boolean { | ||
| if (token.isEmpty()) return false | ||
| if (token.all { it.isDigit() }) return true | ||
| if (token.startsWith("v") && token.drop(1).all { it.isDigit() }) return true | ||
| return false | ||
| } |
Contributor
There was a problem hiding this comment.
Broaden version-token stripping to keep stems stable across prerelease bumps.
At Line 325, isVersionLikeToken() only strips numeric and v-numeric tokens. Qualifier counters like rc1/beta3 leak into stems, so names like AppA-1.0-rc1.apk → AppA-1.0-rc2.apk no longer share a stem and can bypass sibling filtering.
💡 Suggested fix
+ private val QUALIFIER_VERSION_TOKEN =
+ Regex("""^(alpha|beta|rc|pre|preview)\d+$""")
private fun isVersionLikeToken(token: String): Boolean {
- if (token.isEmpty()) return false
- if (token.all { it.isDigit() }) return true
- if (token.startsWith("v") && token.drop(1).all { it.isDigit() }) return true
+ if (token.isEmpty()) return false
+ val t = token.lowercase()
+ if (t.all { it.isDigit() }) return true
+ if (t.startsWith("v") && t.length > 1 && t.drop(1).all { it.isDigit() }) return true
+ if (QUALIFIER_VERSION_TOKEN.matches(t)) return true
return false
}🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In
`@core/domain/src/commonMain/kotlin/zed/rainxch/core/domain/util/AssetVariant.kt`
around lines 325 - 330, The current isVersionLikeToken(token: String) only
recognizes pure digits and v+digits, so qualifier counters like "rc1" or "beta3"
are treated as stem content; update isVersionLikeToken to also recognize and
return true for tokens that combine alphabetical qualifiers with numeric
counters (e.g. "rc1", "beta3", "alpha2" and optionally with a leading 'v', e.g.
"vrc1") by adding a regex/conditional branch that matches patterns like optional
leading 'v' plus letters+digits (and optionally digits+letters if you want to be
liberal), keeping the existing digit and v+digit checks and using the function
name isVersionLikeToken to locate and replace the logic.
|
|
||
| ## Module Structure | ||
|
|
||
| ``` |
Contributor
There was a problem hiding this comment.
Add a language identifier to the fenced code block.
Markdown lint flags this fence as missing language (MD040).
Proposed fix
-```
+```text
feature/recently-viewed/
└── presentation/
├── RecentlyViewedViewModel.kt # Observes seen-repos, exposes UI list
@@
-```
+```🧰 Tools
🪛 markdownlint-cli2 (0.22.1)
[warning] 9-9: Fenced code blocks should have a language specified
(MD040, fenced-code-language)
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@feature/recently-viewed/CLAUDE.md` at line 9, The fenced code block in
CLAUDE.md is missing a language identifier; locate the code fence that starts
with ``` immediately before the directory tree (the block containing
"feature/recently-viewed/" and the list of files) and change the opening fence
to include a language identifier (e.g., ```text) so it reads ```text while
keeping the closing ``` unchanged, which will satisfy the MD040 lint rule.
Contributor
There was a problem hiding this comment.
Actionable comments posted: 3
♻️ Duplicate comments (1)
CLAUDE.md (1)
85-85:⚠️ Potential issue | 🟠 Major | ⚡ Quick winRedact concrete secret-like value in SignPath config docs.
SIGNPATH_ORGANIZATION_IDis documented with a concrete value fragment. Keep only the variable name and where it is configured (CI secret/variable store).Suggested minimal doc fix
-- **Windows installer signing (SignPath Foundation):** CI workflow `.github/workflows/build-desktop-platforms.yml` job `sign-windows` after every push to `generate-installers` branch. Action pinned to commit SHA (not `@v2`). Secrets: `SIGNPATH_API_TOKEN`, `SIGNPATH_ORGANIZATION_ID` (`1ecf111e-...`). Variable `SIGNPATH_SIGNING_POLICY_SLUG` = `test-signing` until prod cert issued; flip to `release-signing`. Project slug `GitHub-Store`, artifact config slug `initial`. Unsigned artifact deleted post-sign; only `windows-installers-signed` reaches the draft release. +- **Windows installer signing (SignPath Foundation):** CI workflow `.github/workflows/build-desktop-platforms.yml` job `sign-windows` after every push to `generate-installers` branch. Action pinned to commit SHA (not `@v2`). Secrets: `SIGNPATH_API_TOKEN`, `SIGNPATH_ORGANIZATION_ID` (set in CI secrets). Variable `SIGNPATH_SIGNING_POLICY_SLUG` = `test-signing` until prod cert issued; flip to `release-signing`. Project slug `GitHub-Store`, artifact config slug `initial`. Unsigned artifact deleted post-sign; only `windows-installers-signed` reaches the draft release.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@CLAUDE.md` at line 85, Remove the concrete GUID fragment shown for SIGNPATH_ORGANIZATION_ID in the CLAUDE.md SignPath config section and replace it with only the variable name and where it should be configured (e.g., CI secret/variable store); locate the text referring to the SignPath config (references to .github/workflows/build-desktop-platforms.yml and job name sign-windows) and redact the example value so only SIGNPATH_ORGANIZATION_ID is shown with an instruction to set it as a secret.
🧹 Nitpick comments (7)
CLAUDE.md (1)
20-20: ⚡ Quick winAdd a language tag to the fenced structure block.
Use
```textfor the tree block to satisfy MD040 and keep docs lint-clean.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@CLAUDE.md` at line 20, The fenced tree block in CLAUDE.md is missing a language tag causing MD040; update the opening fence from ``` to ```text so the block is marked as plain text (e.g., change the triple-backtick that starts the tree block to ```text) to satisfy the linter and keep docs lint-clean.feature/apps/CLAUDE.md (1)
7-7: ⚡ Quick winAdd
textlanguage tag to the structure code fence.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@feature/apps/CLAUDE.md` at line 7, The code fence in CLAUDE.md is missing a language tag; update the triple-backtick fence that wraps the "structure" example to use the text language tag (change ``` to ```text) so the block is marked as plain text and renders correctly.feature/profile/CLAUDE.md (1)
7-7: ⚡ Quick winAdd a language label to the structure code fence.
Please mark this fence as
textto satisfy markdownlint MD040.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@feature/profile/CLAUDE.md` at line 7, The fenced code block in CLAUDE.md should include a language label to satisfy markdownlint MD040; edit the code fence around the example (the triple backticks block at the current content) and add the label "text" immediately after the opening ``` so it reads ```text, leaving the block contents unchanged.feature/details/CLAUDE.md (1)
7-7: ⚡ Quick winAdd a language marker (
text) to this fenced code block.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@feature/details/CLAUDE.md` at line 7, The fenced code block currently uses plain backticks (```) with no language hint; update that block delimiter to include the language marker by replacing the opening fence from ``` to ```text so the code block in CLAUDE.md is explicitly marked as plain text.feature/auth/CLAUDE.md (1)
7-7: ⚡ Quick winSpecify a language for the fenced structure block (
text).🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@feature/auth/CLAUDE.md` at line 7, The fenced code block in CLAUDE.md is missing a language tag; update the opening triple-backtick fence for the structure block to include the language identifier (e.g., "text") so the fenced block is declared as a text block; locate the triple-backtick fence in CLAUDE.md around the structure example and add the language specifier to the opening fence.feature/home/CLAUDE.md (1)
7-7: ⚡ Quick winLabel the fenced tree block with a language (
text).This keeps the doc compliant with markdownlint MD040.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@feature/home/CLAUDE.md` at line 7, The fenced tree block in CLAUDE.md is missing a language label; update the opening triple-backtick for that block (the ``` fence) to include the language identifier text (i.e., change ``` to ```text) so the Markdown lint rule MD040 is satisfied and the block is treated as plain text.feature/dev-profile/CLAUDE.md (1)
7-7: ⚡ Quick winUse a language tag on the structure fence (
text).🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@feature/dev-profile/CLAUDE.md` at line 7, The fenced block ending with ``` is missing a language tag; change the code fence to include the text language tag by using ```text for the opening fence (and keep the closing ```), so the structure fence is explicitly labeled as text.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@feature/favourites/CLAUDE.md`:
- Around line 7-13: The fenced code block in CLAUDE.md is missing a language tag
causing markdownlint MD040; update the opening fence from ``` to a
language-tagged fence such as ```text (or ```bash/```md as appropriate) so the
block is recognized as code/text and the linter warning is resolved — edit the
fenced block that contains the directory tree under the feature/favourites
presentation listing.
In `@feature/search/CLAUDE.md`:
- Around line 7-14: The markdown code fence for the directory tree in
feature/search/CLAUDE.md lacks a language tag (violates MD040); update the
opening fence from ``` to include a language such as ```text (or ```bash) so the
block becomes ```text and preserves the tree formatting—modify the fenced block
that contains the "feature/search/" directory listing to include the language
tag.
In `@feature/starred/CLAUDE.md`:
- Around line 7-14: The fenced code block in feature/starred/CLAUDE.md (the
directory tree snippet under feature/starred/presentation/) is unlabeled; add a
language identifier "text" to the opening triple backticks so it reads ```text
to satisfy MD040; update the fenced block that contains the lines starting with
"feature/starred/presentation/" and the list items (StarredReposViewModel,
model/StarredRepositoryUi, mappers/StarredRepoToUiMapper, utils/TimeFormatUtils,
components/StarredRepositoryItem) to use the labeled fence.
---
Duplicate comments:
In `@CLAUDE.md`:
- Line 85: Remove the concrete GUID fragment shown for SIGNPATH_ORGANIZATION_ID
in the CLAUDE.md SignPath config section and replace it with only the variable
name and where it should be configured (e.g., CI secret/variable store); locate
the text referring to the SignPath config (references to
.github/workflows/build-desktop-platforms.yml and job name sign-windows) and
redact the example value so only SIGNPATH_ORGANIZATION_ID is shown with an
instruction to set it as a secret.
---
Nitpick comments:
In `@CLAUDE.md`:
- Line 20: The fenced tree block in CLAUDE.md is missing a language tag causing
MD040; update the opening fence from ``` to ```text so the block is marked as
plain text (e.g., change the triple-backtick that starts the tree block to
```text) to satisfy the linter and keep docs lint-clean.
In `@feature/apps/CLAUDE.md`:
- Line 7: The code fence in CLAUDE.md is missing a language tag; update the
triple-backtick fence that wraps the "structure" example to use the text
language tag (change ``` to ```text) so the block is marked as plain text and
renders correctly.
In `@feature/auth/CLAUDE.md`:
- Line 7: The fenced code block in CLAUDE.md is missing a language tag; update
the opening triple-backtick fence for the structure block to include the
language identifier (e.g., "text") so the fenced block is declared as a text
block; locate the triple-backtick fence in CLAUDE.md around the structure
example and add the language specifier to the opening fence.
In `@feature/details/CLAUDE.md`:
- Line 7: The fenced code block currently uses plain backticks (```) with no
language hint; update that block delimiter to include the language marker by
replacing the opening fence from ``` to ```text so the code block in CLAUDE.md
is explicitly marked as plain text.
In `@feature/dev-profile/CLAUDE.md`:
- Line 7: The fenced block ending with ``` is missing a language tag; change the
code fence to include the text language tag by using ```text for the opening
fence (and keep the closing ```), so the structure fence is explicitly labeled
as text.
In `@feature/home/CLAUDE.md`:
- Line 7: The fenced tree block in CLAUDE.md is missing a language label; update
the opening triple-backtick for that block (the ``` fence) to include the
language identifier text (i.e., change ``` to ```text) so the Markdown lint rule
MD040 is satisfied and the block is treated as plain text.
In `@feature/profile/CLAUDE.md`:
- Line 7: The fenced code block in CLAUDE.md should include a language label to
satisfy markdownlint MD040; edit the code fence around the example (the triple
backticks block at the current content) and add the label "text" immediately
after the opening ``` so it reads ```text, leaving the block contents unchanged.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: f03c26ea-8764-4b1f-a532-c5441b74d8d6
📒 Files selected for processing (12)
CLAUDE.mdfeature/apps/CLAUDE.mdfeature/auth/CLAUDE.mdfeature/details/CLAUDE.mdfeature/dev-profile/CLAUDE.mdfeature/favourites/CLAUDE.mdfeature/home/CLAUDE.mdfeature/profile/CLAUDE.mdfeature/recently-viewed/CLAUDE.mdfeature/search/CLAUDE.mdfeature/starred/CLAUDE.mdfeature/tweaks/CLAUDE.md
Comment on lines
7
to
13
| ``` | ||
| feature/favourites/ | ||
| └── presentation/ | ||
| ├── FavouritesViewModel.kt # Observes favourites, handles remove | ||
| ├── FavouritesState.kt # favourites list, loading | ||
| ├── FavouritesAction.kt # RemoveFavourite, click actions | ||
| ├── FavouritesRoot.kt # Main composable (list of favourites) | ||
| ├── model/FavouriteRepository.kt # UI model for display | ||
| ├── mappers/FavouriteRepositoryMapper.kt # Domain → UI model mapper | ||
| └── components/FavouriteRepositoryItem.kt # Individual favourite card | ||
| feature/favourites/presentation/ | ||
| ├── FavouritesViewModel / State / Action / Root | ||
| ├── model/FavouriteRepository | ||
| ├── mappers/FavouriteRepositoryMapper | ||
| └── components/FavouriteRepositoryItem | ||
| ``` |
Contributor
There was a problem hiding this comment.
Add a language tag to the fenced block (MD040).
Line 7 opens a fenced code block without a language identifier; markdownlint will keep warning on this file.
Proposed fix
-```
+```text
feature/favourites/presentation/
├── FavouritesViewModel / State / Action / Root
├── model/FavouriteRepository
├── mappers/FavouriteRepositoryMapper
└── components/FavouriteRepositoryItem</details>
<!-- suggestion_start -->
<details>
<summary>📝 Committable suggestion</summary>
> ‼️ **IMPORTANT**
> Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
```suggestion
🧰 Tools
🪛 markdownlint-cli2 (0.22.1)
[warning] 7-7: Fenced code blocks should have a language specified
(MD040, fenced-code-language)
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@feature/favourites/CLAUDE.md` around lines 7 - 13, The fenced code block in
CLAUDE.md is missing a language tag causing markdownlint MD040; update the
opening fence from ``` to a language-tagged fence such as ```text (or
```bash/```md as appropriate) so the block is recognized as code/text and the
linter warning is resolved — edit the fenced block that contains the directory
tree under the feature/favourites presentation listing.
Comment on lines
7
to
14
| ``` | ||
| feature/search/ | ||
| ├── domain/ | ||
| │ ├── model/ | ||
| │ │ ├── SearchPlatform.kt # All, Android, Windows, macOS, Linux | ||
| │ │ ├── ProgrammingLanguage.kt # Language filter options | ||
| │ │ └── SortBy.kt # Sort options (stars, updated, etc.) | ||
| │ └── repository/SearchRepository.kt # Filtered, paginated search | ||
| ├── data/ | ||
| │ ├── di/SharedModule.kt # Koin: searchModule | ||
| │ ├── repository/SearchRepositoryImpl.kt # GitHub search API integration | ||
| │ ├── dto/ # Network DTOs | ||
| │ └── mappers/ # DTO → domain model mappers | ||
| ├── domain/ # SearchRepository; SearchPlatform (All/Android/Macos/Windows/Linux), ProgrammingLanguage, SortBy | ||
| ├── data/ # SearchRepositoryImpl + dto + mappers + di | ||
| └── presentation/ | ||
| ├── SearchViewModel.kt # Search state, filter management, pagination | ||
| ├── SearchState.kt # query, results, filters, loading state | ||
| ├── SearchAction.kt # Search, filter changes, load more, clicks | ||
| ├── SearchEvent.kt # One-off events | ||
| ├── SearchRoot.kt # Main composable with search bar + filter dropdowns | ||
| └── components/ # Filter UI components | ||
| ├── SearchViewModel / State / Action / Event / Root | ||
| └── components/ filter chips, ClipboardLinkBanner, etc. | ||
| ``` |
Contributor
There was a problem hiding this comment.
Specify a language for the directory-tree fence (MD040).
Line 7 should include a fence language to satisfy markdownlint.
Proposed fix
-```
+```text
feature/search/
├── domain/ # SearchRepository; SearchPlatform (All/Android/Macos/Windows/Linux), ProgrammingLanguage, SortBy
├── data/ # SearchRepositoryImpl + dto + mappers + di
└── presentation/
├── SearchViewModel / State / Action / Event / Root
└── components/ filter chips, ClipboardLinkBanner, etc.</details>
<details>
<summary>🧰 Tools</summary>
<details>
<summary>🪛 markdownlint-cli2 (0.22.1)</summary>
[warning] 7-7: Fenced code blocks should have a language specified
(MD040, fenced-code-language)
</details>
</details>
<details>
<summary>🤖 Prompt for AI Agents</summary>
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In @feature/search/CLAUDE.md around lines 7 - 14, The markdown code fence for
the directory tree in feature/search/CLAUDE.md lacks a language tag (violates
MD040); update the opening fence from to include a language such astext
(or bash) so the block becomes text and preserves the tree
formatting—modify the fenced block that contains the "feature/search/" directory
listing to include the language tag.
</details>
<!-- fingerprinting:phantom:triton:hawk -->
<!-- This is an auto-generated comment by CodeRabbit -->
Comment on lines
7
to
14
| ``` | ||
| feature/starred/ | ||
| └── presentation/ | ||
| ├── StarredReposViewModel.kt # Observes starred repos, handles remove | ||
| ├── StarredReposState.kt # starred list, loading | ||
| ├── StarredReposAction.kt # RemoveStarred, click actions | ||
| ├── StarredReposRoot.kt # Main composable (list of starred repos) | ||
| ├── model/StarredRepositoryUi.kt # UI model for display | ||
| ├── mappers/StarredRepoToUiMapper.kt # Domain → UI model mapper | ||
| ├── utils/TimeFormatUtils.kt # Time formatting utilities | ||
| └── components/StarredRepositoryItem.kt # Individual starred repo card | ||
| feature/starred/presentation/ | ||
| ├── StarredReposViewModel / State / Action / Root | ||
| ├── model/StarredRepositoryUi | ||
| ├── mappers/StarredRepoToUiMapper | ||
| ├── utils/TimeFormatUtils | ||
| └── components/StarredRepositoryItem | ||
| ``` |
Contributor
There was a problem hiding this comment.
Add a language identifier to the fenced block (MD040).
Line 7 opens an unlabeled code fence; add text to clear markdownlint.
Proposed fix
-```
+```text
feature/starred/presentation/
├── StarredReposViewModel / State / Action / Root
├── model/StarredRepositoryUi
├── mappers/StarredRepoToUiMapper
├── utils/TimeFormatUtils
└── components/StarredRepositoryItem</details>
<details>
<summary>🧰 Tools</summary>
<details>
<summary>🪛 markdownlint-cli2 (0.22.1)</summary>
[warning] 7-7: Fenced code blocks should have a language specified
(MD040, fenced-code-language)
</details>
</details>
<details>
<summary>🤖 Prompt for AI Agents</summary>
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In @feature/starred/CLAUDE.md around lines 7 - 14, The fenced code block in
feature/starred/CLAUDE.md (the directory tree snippet under
feature/starred/presentation/) is unlabeled; add a language identifier "text" to
the opening triple backticks so it reads ```text to satisfy MD040; update the
fenced block that contains the lines starting with
"feature/starred/presentation/" and the list items (StarredReposViewModel,
model/StarredRepositoryUi, mappers/StarredRepoToUiMapper, utils/TimeFormatUtils,
components/StarredRepositoryItem) to use the labeled fence.
</details>
<!-- fingerprinting:phantom:triton:hawk -->
<!-- This is an auto-generated comment by CodeRabbit -->
Contributor
There was a problem hiding this comment.
♻️ Duplicate comments (1)
CLAUDE.md (1)
85-85:⚠️ Potential issue | 🟠 Major | ⚡ Quick winRedact concrete secret-like value from signing docs (Line 85).
SIGNPATH_ORGANIZATION_IDis listed under secrets but still shows a concrete value fragment (1ecf111e-...). Keep only the variable name and where it is configured (CI secret/variable store).🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@CLAUDE.md` at line 85, Remove the concrete fragment from the SIGNPATH_ORGANIZATION_ID entry and replace it with only the variable name and where it is configured (e.g., "SIGNPATH_ORGANIZATION_ID — configured in CI secrets/variable store"); update the CLAUDE.md reference to SIGNPATH_ORGANIZATION_ID so it no longer includes the partial value "1ecf111e-..." and ensure other signing-related entries (e.g., SIGNPATH_API_TOKEN, SIGNPATH_SIGNING_POLICY_SLUG) similarly list only variable names and configuration locations.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Duplicate comments:
In `@CLAUDE.md`:
- Line 85: Remove the concrete fragment from the SIGNPATH_ORGANIZATION_ID entry
and replace it with only the variable name and where it is configured (e.g.,
"SIGNPATH_ORGANIZATION_ID — configured in CI secrets/variable store"); update
the CLAUDE.md reference to SIGNPATH_ORGANIZATION_ID so it no longer includes the
partial value "1ecf111e-..." and ensure other signing-related entries (e.g.,
SIGNPATH_API_TOKEN, SIGNPATH_SIGNING_POLICY_SLUG) similarly list only variable
names and configuration locations.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bring all CLAUDE.md files up to date with the merged 1.8.2 scope.
Root
CLAUDE.md:feature/tweaks/,feature/recently-viewed/to module treecore/domaininterface list expanded to include SeenReposRepository, HiddenReposRepository, SearchHistoryRepository, TweaksRepository, AuthenticationState, ExternalImportRepository, TelemetryRepository +AssetVariantutil +assetPlatformOfNew feature CLAUDE.md:
feature/tweaks/CLAUDE.md— settings home module, sub-screens (skipped, hidden, mirror, feedback), DataStore-backed coachmarks, multi-platform asset toggle wiringfeature/recently-viewed/CLAUDE.md— SeenReposRepository-backed history viewUpdated feature CLAUDE.md:
apps/— sort + search, ignore/skip per-app, APK Inspect, lifecycle resume, external-import wizard, starred picker sub-featuresauth/— backend-proxied device flow path, AuthPath persistence, rate limits, X-Request-ID conventiondetails/— multi-OS picker (E15), coachmarks, self-owned badge plumbing, skipped-release tracking, full injection listfavourites/+starred/— search bar (E562), ProfileRepository dep, E20 self-owned flaghome/+search/— full VM injection list, hide/seen render-time filter, contextual action sheet, E20 plumbingprofile/— narrowed scope: settings moved out tofeature/tweaks/; module now owns account identity + ProfileRepository.getUser() that other features consumeSummary by CodeRabbit
New Features
Bug Fixes
Documentation