-
-
Notifications
You must be signed in to change notification settings - Fork 499
feat(markdown): native SVG decoder + theme-aware images + browser UA #618
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
50 changes: 50 additions & 0 deletions
50
core/domain/src/commonMain/kotlin/zed/rainxch/core/domain/util/applyThemeAwareImages.kt
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,50 @@ | ||
| package zed.rainxch.core.domain.util | ||
|
|
||
| fun applyThemeAwareImages( | ||
| content: String, | ||
| isDark: Boolean, | ||
| ): String { | ||
| if (content.isEmpty()) return content | ||
| var processed = content | ||
|
|
||
| // Strip markdown-image entries whose URL has `#gh-dark-mode-only` | ||
| // or `#gh-light-mode-only` and we're on the OTHER theme. GitHub's | ||
| // own renderer hides these on the mismatched theme; emulating that | ||
| // keeps READMEs from showing both light + dark variants stacked. | ||
| processed = processed.replace( | ||
| Regex("""!\[([^\]]*)\]\(([^)]*?)#gh-(dark|light)-mode-only([^)]*)\)"""), | ||
| ) { match -> | ||
| val mode = match.groupValues[3] | ||
| if ((isDark && mode == "light") || (!isDark && mode == "dark")) { | ||
| "" // drop entirely; alt text would just be noise here | ||
| } else { | ||
| // Strip the fragment so the URL is clean for Coil's cache key. | ||
| val alt = match.groupValues[1] | ||
| val urlBase = match.groupValues[2] | ||
| val trailing = match.groupValues[4] | ||
| "" | ||
| } | ||
| } | ||
|
|
||
| // Same for raw HTML <img> tags. | ||
| processed = processed.replace( | ||
| Regex( | ||
| """<img(\s[^>]*?)src\s*=\s*(["'])([^"']*?)#gh-(dark|light)-mode-only([^"']*?)\2([^>]*?)>""", | ||
| RegexOption.IGNORE_CASE, | ||
| ), | ||
| ) { match -> | ||
| val mode = match.groupValues[4] | ||
| if ((isDark && mode == "light") || (!isDark && mode == "dark")) { | ||
| "" | ||
| } else { | ||
| val pre = match.groupValues[1] | ||
| val quote = match.groupValues[2] | ||
| val urlBase = match.groupValues[3] | ||
| val trailing = match.groupValues[5] | ||
| val post = match.groupValues[6] | ||
| "<img${pre}src=$quote$urlBase$trailing$quote$post>" | ||
| } | ||
| } | ||
|
|
||
| return processed | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removing mismatched themed images can leave empty markdown links.
At Line 19, returning
""for mismatched variants can turn linked images into[](...)artifacts when the image is wrapped in a link.Suggested patch
processed = processed.replace( Regex("""!\[([^\]]*)\]\(([^)]*?)`#gh-`(dark|light)-mode-only([^)]*)\)"""), ) { match -> @@ } } + + // Cleanup empty markdown links left after dropping mismatched linked images. + processed = processed.replace(Regex("""\[\s*\]\(([^)]+)\)"""), "")📝 Committable suggestion
🤖 Prompt for AI Agents