feat(link): trust manual asset pick, skip re-download verification#627
Merged
Conversation
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
rainxchzed has reached the 50-review limit for trial accounts. To continue receiving code reviews, upgrade your plan.
Contributor
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (27)
WalkthroughThis PR implements and documents a simplified manual app linking flow: user-selected assets are immediately trusted without downloading and verifying the signing key. Release notes, all 14 localized banner strings, and the app linking logic are updated together to support this behavior change. ChangesManual App Linking Trust Flow
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Poem
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sprint 3 Task 15. Email feedback (vbidv): manual app matching re-downloaded the picked APK to verify package + signing key, then linked. User already saw the asset in the picker and chose deliberately — re-download wastes bandwidth + time for verification the user can't override anyway.
Changes:
Removed code paths (re-download progress UI, signing-key error state, file cleanup) stay in the codebase implicitly — `Res.string.signing_key_mismatch_link`, `downloading_for_verification`, `download_failed`, `verifying_signing_key` are now orphan but harmless.
Test plan
Summary by CodeRabbit
Release Notes
New Features
Bug Fixes