Skip to content

build-one: add firmware_ref input for cross-repo bisect #94

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
widgetii merged 1 commit into from
May 24, 2026
Merged

build-one: add firmware_ref input for cross-repo bisect #94

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion .github/workflows/build-one.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,10 @@ on:
description: 'Platform to build (e.g. hi3518ev200_lite_switcam-hs303-v2)'
required: true
commit:
description: 'Commit SHA to build (optional; defaults to current branch HEAD). Use this from `git bisect run` or for one-off historic rebuilds.'
description: 'Builder commit SHA to build (optional; defaults to current branch HEAD). Use this from `git bisect run` or for one-off historic rebuilds.'
required: false
firmware_ref:
description: 'OpenIPC/firmware ref (SHA/tag/branch) to clone — for cross-repo bisect of size/regression issues. Defaults to firmware HEAD.'
required: false

jobs:
Expand Down Expand Up @@ -60,6 +63,7 @@ jobs:
BUILD_ID: ${{ needs.resolve.outputs.tag_name }}
BUILD_SHA: ${{ needs.resolve.outputs.ref }}
BUILD_PLATFORM: ${{ inputs.platform }}
OPENIPC_FW_REV: ${{ inputs.firmware_ref }}
run: |
export GIT_HASH=$(git rev-parse --short ${GITHUB_SHA})
export GIT_BRANCH=${GITHUB_REF_NAME}
Expand Down
13 changes: 11 additions & 2 deletions builder.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -124,9 +124,18 @@ echo_c 33 "\nUpdating Builder"
git pull

rm -rf openipc
# OPENIPC_FW_REV pins firmware to a specific ref (branch, tag, or SHA) for
# cross-repo bisect of size/regression issues — set by build-one.yml's
# firmware_ref input. When unset, clones HEAD of master as before.
if [ ! -d "$FIRMWARE_DIR" ]; then
echo_c 33 "\nDownloading Firmware"
git clone --depth=1 https://github.com/OpenIPC/firmware.git "$FIRMWARE_DIR"
if [ -n "$OPENIPC_FW_REV" ]; then
echo_c 33 "\nDownloading Firmware @ ${OPENIPC_FW_REV}"
git clone https://github.com/OpenIPC/firmware.git "$FIRMWARE_DIR"
git -C "$FIRMWARE_DIR" checkout "$OPENIPC_FW_REV"
else
echo_c 33 "\nDownloading Firmware"
git clone --depth=1 https://github.com/OpenIPC/firmware.git "$FIRMWARE_DIR"
fi
cd "$FIRMWARE_DIR"
else
echo_c 33 "\nUpdating Firmware"
Expand Down