xg521: update device override for 60fps→high-fps rename in firmware#95
Merged
Merged
Conversation
OpenIPC/firmware PR #2090 (2026-05-13, "IMX335 companion to openhisilicon #99") renamed `general/package/goke-osdrv-gk7205v200/ files/sensor/config/60fps/` to `high-fps/`. The xg521 device-specific goke-osdrv-gk7205v200.mk override here still references the old path, causing every cron build of gk7202v300_lite_xg521 to fail: /usr/bin/install: cannot stat 'general/package/goke-osdrv-gk7205v200// files/sensor/config/60fps/*.ini': No such file or directory Update the two install lines to use `high-fps` matching the renamed upstream directory. Target install path also moves from /etc/sensors/60fps → /etc/sensors/high-fps for consistency with what the rest of the V4 sensor presets use. The matching exclude-list entry in devices/gk7202v300_lite_xg521/general/scripts/excludes/gk7202v300_lite.list references /etc/sensors/60fps/... and is now stale; left as-is since `rm -f` on a non-existent path is a no-op (rootfs_script.sh: xargs -I % rm -f ${TARGET_DIR}%). Can be cleaned in a follow-up. Other Goke device overlays (gk7205v200_lite_*, gk7205v210_lite_*, gk7205v300_lite_*) only have the same exclude-list staleness and no broken install rule, so they aren't affected by this bug. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The xg521 device-specific override at
devices/gk7202v300_lite_xg521/general/package/goke-osdrv-gk7205v200/goke-osdrv-gk7205v200.mkreferences/etc/sensors/60fpsandfiles/sensor/config/60fps/*.ini. OpenIPC/firmware#2090 (2026-05-13, "IMX335 companion to openhisilicon #99") renamed the upstream directory60fps/→high-fps/. Every cron build ofgk7202v300_lite_xg521since then has failed:Two-line fix: change both install rules to use
high-fps. Target install path moves from/etc/sensors/60fps→/etc/sensors/high-fpsto match the rest of the V4 sensor presets.Notes
devices/gk7202v300_lite_xg521/general/scripts/excludes/gk7202v300_lite.list(/etc/sensors/60fps/720p_imx307_i2c_2l.ini) is now stale, but harmless —rootfs_script.shusesrm -f(no-op on missing path). Cleanup can be a follow-up..mkoverride that diverged.Test plan
gh workflow run build-one.yml -f platform=gk7202v300_lite_xg521produces a successful build.gk7202v300_lite_xg521matrix entry passes; result lands in thehttps://openipc.github.io/builder/manifest.flatindex for the first time since 2026-05-13.See also
hi3516ev200-ev300-fpv-rootfs-size-overflow-2026-05-24for the broader sweep of 2026-05-13 sensor-work fallout (also includes the unrelated fpv variant rootfs overflow).🤖 Generated with Claude Code