Fix flash dump: RAM addresses, CRC32 verification, modal UX#8
Merged
Fix flash dump: RAM addresses, CRC32 verification, modal UX#8
Conversation
RAM address fix: - Added RAM_BASE map from qemu-hisilicon for all SoC families - get_ram_staging_addr() returns correct address per chip - hi3516ev300: 0x42000000 (was 0x82000000 which caused data abort) Per-block CRC32 verification: - Detects if U-Boot has crc32 command (optional, graceful fallback) - After each 4KB block: device crc32 vs local zlib.crc32 - Mismatch triggers retry (up to 3 attempts, like XMODEM) - Stats: verified/total blocks, error count, retry count Modal transfer dialog (HyperTerminal-style): - Progress bar + live transfer stats - Blocks done/total, speed (KB/s), elapsed time, ETA - CRC32 verification status, error rate, retries - Cancel: graceful (finishes current block, Ctrl-C to U-Boot, drains serial, clears terminal — no artifacts) - Return to Terminal button after completion/cancel Other fixes: - Ctrl-D/S/C handled directly in on_key (TextArea was swallowing them) - Reduced chunk size to 4KB for reliable serial transfer - *.bin added to .gitignore Tests: 28 flashdump tests (RAM addresses, CRC32 parsing, detection) Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Verified on real hardware
Test plan
🤖 Generated with Claude Code