When run without arguments, ipctool prints a summary about the device information, as is documented in the README.
However, it also starts a background process that uploads the entire device storage to an S3 bucket, without asking for confirmation from the user, nor even letting them know that this is happening. This behaviour is not documented anywhere, and it is completely unexpected given the description of the tool.
This "feature" may have been implemented with the best intentions, but the collected data contains personal information, such as /etc/passwd files, wifi passwords, SSL/SSH/VPN keys, etc. As such, it is in violation of the GDPR. As a general principle, if you want the user's help in collecting device information, you should ask for that help, not do it behind the user's back. Users of unsuported devices will be more than happy to assist you, and you'll also avoid getting firmware dumps for devices you already support.
I'm happy to provide a patch removing this unwanted behavior, but first I'm curious to hear your thoughts on this.
When run without arguments, ipctool prints a summary about the device information, as is documented in the README.
However, it also starts a background process that uploads the entire device storage to an S3 bucket, without asking for confirmation from the user, nor even letting them know that this is happening. This behaviour is not documented anywhere, and it is completely unexpected given the description of the tool.
This "feature" may have been implemented with the best intentions, but the collected data contains personal information, such as /etc/passwd files, wifi passwords, SSL/SSH/VPN keys, etc. As such, it is in violation of the GDPR. As a general principle, if you want the user's help in collecting device information, you should ask for that help, not do it behind the user's back. Users of unsuported devices will be more than happy to assist you, and you'll also avoid getting firmware dumps for devices you already support.
I'm happy to provide a patch removing this unwanted behavior, but first I'm curious to hear your thoughts on this.