Skip to content

Fix for compatibility with OpenMDAO:3.39#103

Merged
Kenneth-T-Moore merged 2 commits intoOpenMDAO:masterfrom
Kenneth-T-Moore:om3.39
Jun 26, 2025
Merged

Fix for compatibility with OpenMDAO:3.39#103
Kenneth-T-Moore merged 2 commits intoOpenMDAO:masterfrom
Kenneth-T-Moore:om3.39

Conversation

@Kenneth-T-Moore
Copy link
Member

@Kenneth-T-Moore Kenneth-T-Moore commented Jun 17, 2025

Summary

  1. Modified some of the viewers to adapt to the loss of hybrid promoted names in OpenMDAO 3.39.
  2. Added a benchmark that runs the cycle examples so that we can be warned when something goes wrong with them.

Related Issues

Backwards incompatibilities

None

New Dependencies

None

@Kenneth-T-Moore
Copy link
Member Author

@drhode-icct @arushkumarsingh
Can you let me know if this fixes the problem for your models?

@drhode-icct
Copy link

drhode-icct commented Jun 17, 2025

Yes @Kenneth-T-Moore @arushkumarsingh , this fixes the errors I had with the viewer file, also required some modifications to my own model to work properly (since I was referring to add_cycle_param variables as PNT_name.variable_name. Now that this is not possible, maybe mentioning this in the release notes could be helpful for other users.) Thanks for the fix!

@arushkumarsingh
Copy link
Contributor

Yeah, it works,

Will need a change in this function, as sometimes units are also passed to get a value.
def get_val(prob, point, element, var_name)

Changes to:

def get_val(prob, point, element, var_name, units=None)
val = prob.get_val(f"{point}.{element}.{var_name}", units = units)
val = prob.get_val(f"{element}.{var_name}", units=units)

@Kenneth-T-Moore
Copy link
Member Author

Hey, @arushkumarsingh
I've got a units argument added to the get_val call, so that you can convert between compatible openmdao units.

@Kenneth-T-Moore Kenneth-T-Moore merged commit 68af424 into OpenMDAO:master Jun 26, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Compatibility with OpenMDAO 3.39.0

4 participants